Skip to content

Commit b4b3242

Browse files
phy: ti: phy-j721e-wiz: fix usxgmii configuration
Commit b64a85f ("phy: ti: phy-j721e-wiz.c: Add usxgmii support in wiz driver") added support for USXGMII mode. In doing so, P0_REFCLK_SEL was set to "pcs_mac_clk_divx1_ln_0" (0x3) and P0_STANDARD_MODE was set to LANE_MODE_GEN1, which results in a data rate of 5.15625 Gbps. However, since the USXGMII mode can support up to 10.3125 Gbps data rate, the aforementioned fields should be set to "pcs_mac_clk_divx0_ln_0" (0x2) and LANE_MODE_GEN2 respectively. The signal corresponding to the USXGMII lane of the SERDES has been measured as 5 Gbps without the change and 10 Gbps with the change. Hence, fix the configuration accordingly to support USXGMII up to 10G. Fixes: b64a85f ("phy: ti: phy-j721e-wiz.c: Add usxgmii support in wiz driver") Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com> Reviewed-by: Roger Quadros <rogerq@kernel.org> Link: https://lore.kernel.org/r/20241012053937.3596885-1-s-vadapalli@ti.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent e10c52e commit b4b3242

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/phy/ti/phy-j721e-wiz.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -450,8 +450,8 @@ static int wiz_mode_select(struct wiz *wiz)
450450
} else if (wiz->lane_phy_type[i] == PHY_TYPE_USXGMII) {
451451
ret = regmap_field_write(wiz->p0_mac_src_sel[i], 0x3);
452452
ret = regmap_field_write(wiz->p0_rxfclk_sel[i], 0x3);
453-
ret = regmap_field_write(wiz->p0_refclk_sel[i], 0x3);
454-
mode = LANE_MODE_GEN1;
453+
ret = regmap_field_write(wiz->p0_refclk_sel[i], 0x2);
454+
mode = LANE_MODE_GEN2;
455455
} else {
456456
continue;
457457
}

0 commit comments

Comments
 (0)