Skip to content

Commit adf8623

Browse files
committed
KVM: arm64: Use KVM_REQ_RELOAD_PMU to handle PMCR_EL0.E change
Nested virt introduces yet another set of 'global' knobs for controlling event counters that are reserved for EL2 (i.e. >= HPMN). Get ready to share some plumbing with the NV controls by offloading counter reprogramming to KVM_REQ_RELOAD_PMU. Reviewed-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20241217175532.3658134-1-oliver.upton@linux.dev Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
1 parent e22c369 commit adf8623

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

arch/arm64/kvm/pmu-emul.c

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -606,17 +606,13 @@ void kvm_pmu_handle_pmcr(struct kvm_vcpu *vcpu, u64 val)
606606
if (!kvm_has_feat(vcpu->kvm, ID_AA64DFR0_EL1, PMUVer, V3P5))
607607
val &= ~ARMV8_PMU_PMCR_LP;
608608

609+
/* Request a reload of the PMU to enable/disable affected counters */
610+
if ((__vcpu_sys_reg(vcpu, PMCR_EL0) ^ val) & ARMV8_PMU_PMCR_E)
611+
kvm_make_request(KVM_REQ_RELOAD_PMU, vcpu);
612+
609613
/* The reset bits don't indicate any state, and shouldn't be saved. */
610614
__vcpu_sys_reg(vcpu, PMCR_EL0) = val & ~(ARMV8_PMU_PMCR_C | ARMV8_PMU_PMCR_P);
611615

612-
if (val & ARMV8_PMU_PMCR_E) {
613-
kvm_pmu_reprogram_counter_mask(vcpu,
614-
__vcpu_sys_reg(vcpu, PMCNTENSET_EL0));
615-
} else {
616-
kvm_pmu_reprogram_counter_mask(vcpu,
617-
__vcpu_sys_reg(vcpu, PMCNTENSET_EL0));
618-
}
619-
620616
if (val & ARMV8_PMU_PMCR_C)
621617
kvm_pmu_set_counter_value(vcpu, ARMV8_PMU_CYCLE_IDX, 0);
622618

@@ -626,7 +622,6 @@ void kvm_pmu_handle_pmcr(struct kvm_vcpu *vcpu, u64 val)
626622
for_each_set_bit(i, &mask, 32)
627623
kvm_pmu_set_pmc_value(kvm_vcpu_idx_to_pmc(vcpu, i), 0, true);
628624
}
629-
kvm_vcpu_pmu_restore_guest(vcpu);
630625
}
631626

632627
static bool kvm_pmu_counter_is_enabled(struct kvm_pmc *pmc)
@@ -890,11 +885,11 @@ void kvm_vcpu_reload_pmu(struct kvm_vcpu *vcpu)
890885
{
891886
u64 mask = kvm_pmu_implemented_counter_mask(vcpu);
892887

893-
kvm_pmu_handle_pmcr(vcpu, kvm_vcpu_read_pmcr(vcpu));
894-
895888
__vcpu_sys_reg(vcpu, PMOVSSET_EL0) &= mask;
896889
__vcpu_sys_reg(vcpu, PMINTENSET_EL1) &= mask;
897890
__vcpu_sys_reg(vcpu, PMCNTENSET_EL0) &= mask;
891+
892+
kvm_pmu_reprogram_counter_mask(vcpu, mask);
898893
}
899894

900895
int kvm_arm_pmu_v3_enable(struct kvm_vcpu *vcpu)

0 commit comments

Comments
 (0)