Skip to content

Commit ac9fae7

Browse files
committed
ALSA: compress_offload: Drop unneeded no_free_ptr()
The error path for memdup_user() no longer needs the tricky wrap with no_free_ptr() and we can safely return the error pointer directly. Fixes: 0417715 ("ALSA: compress_offload: introduce accel operation mode") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202412290846.cncnpGaw-lkp@intel.com/ Link: https://patch.msgid.link/20241229083917.14912-1-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 6a451e2 commit ac9fae7

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

sound/core/compress_offload.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1077,7 +1077,7 @@ static int snd_compr_task_create(struct snd_compr_stream *stream, unsigned long
10771077
return -EPERM;
10781078
task = memdup_user((void __user *)arg, sizeof(*task));
10791079
if (IS_ERR(task))
1080-
return PTR_ERR(no_free_ptr(task));
1080+
return PTR_ERR(task);
10811081
retval = snd_compr_task_new(stream, task);
10821082
if (retval >= 0)
10831083
if (copy_to_user((void __user *)arg, task, sizeof(*task)))
@@ -1138,7 +1138,7 @@ static int snd_compr_task_start_ioctl(struct snd_compr_stream *stream, unsigned
11381138
return -EPERM;
11391139
task = memdup_user((void __user *)arg, sizeof(*task));
11401140
if (IS_ERR(task))
1141-
return PTR_ERR(no_free_ptr(task));
1141+
return PTR_ERR(task);
11421142
retval = snd_compr_task_start(stream, task);
11431143
if (retval >= 0)
11441144
if (copy_to_user((void __user *)arg, task, sizeof(*task)))
@@ -1229,7 +1229,7 @@ static int snd_compr_task_status_ioctl(struct snd_compr_stream *stream, unsigned
12291229
return -EPERM;
12301230
status = memdup_user((void __user *)arg, sizeof(*status));
12311231
if (IS_ERR(status))
1232-
return PTR_ERR(no_free_ptr(status));
1232+
return PTR_ERR(status);
12331233
retval = snd_compr_task_status(stream, status);
12341234
if (retval >= 0)
12351235
if (copy_to_user((void __user *)arg, status, sizeof(*status)))

0 commit comments

Comments
 (0)