Skip to content

Commit abbff41

Browse files
committed
Revert "ALSA: ump: Don't enumeration invalid groups for legacy rawmidi"
This reverts commit c2d188e. Although it's fine to filter the invalid UMP groups at the first probe time, this will become a problem when UMP groups are updated and (re-)activated. Then there is no way to re-add the substreams properly for the legacy rawmidi, and the new active groups will be still invisible. So let's revert the change. This will move back to showing the full 16 groups, but it's better than forever lost. Link: https://patch.msgid.link/20241230114023.3787-1-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 0179488 commit abbff41

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/core/ump.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1244,7 +1244,7 @@ static int fill_legacy_mapping(struct snd_ump_endpoint *ump)
12441244

12451245
num = 0;
12461246
for (i = 0; i < SNDRV_UMP_MAX_GROUPS; i++)
1247-
if ((group_maps & (1U << i)) && ump->groups[i].valid)
1247+
if (group_maps & (1U << i))
12481248
ump->legacy_mapping[num++] = i;
12491249

12501250
return num;

0 commit comments

Comments
 (0)