Skip to content

Commit aa2eb2c

Browse files
superna9999bebarino
authored andcommitted
clk: qcom: gcc-sm8650: Don't use shared clk_ops for QUPs
The QUPs aren't shared in a way that requires parking the RCG at an always on parent in case some other entity turns on the clk. The hardware is capable of setting a new frequency itself with the DFS mode, so parking is unnecessary. Furthermore, there aren't any GDSCs for these devices, so there isn't a possibility of the GDSC turning on the clks for housekeeping purposes. Like for the SM8550 GCC QUP clocks at [1], do not use shared clk_ops for QUPs. [1] https://lore.kernel.org/all/20240827231237.1014813-3-swboyd@chromium.org/ Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://lore.kernel.org/r/20240829-topic-sm8650-upstream-fix-qup-clk-rcg-shared-v1-1-7ecdbc672187@linaro.org Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 7b6dfa1 commit aa2eb2c

File tree

1 file changed

+28
-28
lines changed

1 file changed

+28
-28
lines changed

drivers/clk/qcom/gcc-sm8650.c

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -713,7 +713,7 @@ static struct clk_rcg2 gcc_qupv3_i2c_s0_clk_src = {
713713
.parent_data = gcc_parent_data_0,
714714
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
715715
.flags = CLK_SET_RATE_PARENT,
716-
.ops = &clk_rcg2_shared_ops,
716+
.ops = &clk_rcg2_ops,
717717
},
718718
};
719719

@@ -728,7 +728,7 @@ static struct clk_rcg2 gcc_qupv3_i2c_s1_clk_src = {
728728
.parent_data = gcc_parent_data_0,
729729
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
730730
.flags = CLK_SET_RATE_PARENT,
731-
.ops = &clk_rcg2_shared_ops,
731+
.ops = &clk_rcg2_ops,
732732
},
733733
};
734734

@@ -743,7 +743,7 @@ static struct clk_rcg2 gcc_qupv3_i2c_s2_clk_src = {
743743
.parent_data = gcc_parent_data_0,
744744
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
745745
.flags = CLK_SET_RATE_PARENT,
746-
.ops = &clk_rcg2_shared_ops,
746+
.ops = &clk_rcg2_ops,
747747
},
748748
};
749749

@@ -758,7 +758,7 @@ static struct clk_rcg2 gcc_qupv3_i2c_s3_clk_src = {
758758
.parent_data = gcc_parent_data_0,
759759
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
760760
.flags = CLK_SET_RATE_PARENT,
761-
.ops = &clk_rcg2_shared_ops,
761+
.ops = &clk_rcg2_ops,
762762
},
763763
};
764764

@@ -773,7 +773,7 @@ static struct clk_rcg2 gcc_qupv3_i2c_s4_clk_src = {
773773
.parent_data = gcc_parent_data_0,
774774
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
775775
.flags = CLK_SET_RATE_PARENT,
776-
.ops = &clk_rcg2_shared_ops,
776+
.ops = &clk_rcg2_ops,
777777
},
778778
};
779779

@@ -788,7 +788,7 @@ static struct clk_rcg2 gcc_qupv3_i2c_s5_clk_src = {
788788
.parent_data = gcc_parent_data_0,
789789
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
790790
.flags = CLK_SET_RATE_PARENT,
791-
.ops = &clk_rcg2_shared_ops,
791+
.ops = &clk_rcg2_ops,
792792
},
793793
};
794794

@@ -803,7 +803,7 @@ static struct clk_rcg2 gcc_qupv3_i2c_s6_clk_src = {
803803
.parent_data = gcc_parent_data_0,
804804
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
805805
.flags = CLK_SET_RATE_PARENT,
806-
.ops = &clk_rcg2_shared_ops,
806+
.ops = &clk_rcg2_ops,
807807
},
808808
};
809809

@@ -818,7 +818,7 @@ static struct clk_rcg2 gcc_qupv3_i2c_s7_clk_src = {
818818
.parent_data = gcc_parent_data_0,
819819
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
820820
.flags = CLK_SET_RATE_PARENT,
821-
.ops = &clk_rcg2_shared_ops,
821+
.ops = &clk_rcg2_ops,
822822
},
823823
};
824824

@@ -833,7 +833,7 @@ static struct clk_rcg2 gcc_qupv3_i2c_s8_clk_src = {
833833
.parent_data = gcc_parent_data_0,
834834
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
835835
.flags = CLK_SET_RATE_PARENT,
836-
.ops = &clk_rcg2_shared_ops,
836+
.ops = &clk_rcg2_ops,
837837
},
838838
};
839839

@@ -848,7 +848,7 @@ static struct clk_rcg2 gcc_qupv3_i2c_s9_clk_src = {
848848
.parent_data = gcc_parent_data_0,
849849
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
850850
.flags = CLK_SET_RATE_PARENT,
851-
.ops = &clk_rcg2_shared_ops,
851+
.ops = &clk_rcg2_ops,
852852
},
853853
};
854854

@@ -863,7 +863,7 @@ static struct clk_init_data gcc_qupv3_wrap1_qspi_ref_clk_src_init = {
863863
.parent_data = gcc_parent_data_0,
864864
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
865865
.flags = CLK_SET_RATE_PARENT,
866-
.ops = &clk_rcg2_shared_ops,
866+
.ops = &clk_rcg2_ops,
867867
};
868868

869869
static struct clk_rcg2 gcc_qupv3_wrap1_qspi_ref_clk_src = {
@@ -899,7 +899,7 @@ static struct clk_init_data gcc_qupv3_wrap1_s0_clk_src_init = {
899899
.parent_data = gcc_parent_data_0,
900900
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
901901
.flags = CLK_SET_RATE_PARENT,
902-
.ops = &clk_rcg2_shared_ops,
902+
.ops = &clk_rcg2_ops,
903903
};
904904

905905
static struct clk_rcg2 gcc_qupv3_wrap1_s0_clk_src = {
@@ -916,7 +916,7 @@ static struct clk_init_data gcc_qupv3_wrap1_s1_clk_src_init = {
916916
.parent_data = gcc_parent_data_0,
917917
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
918918
.flags = CLK_SET_RATE_PARENT,
919-
.ops = &clk_rcg2_shared_ops,
919+
.ops = &clk_rcg2_ops,
920920
};
921921

922922
static struct clk_rcg2 gcc_qupv3_wrap1_s1_clk_src = {
@@ -948,7 +948,7 @@ static struct clk_init_data gcc_qupv3_wrap1_s3_clk_src_init = {
948948
.parent_data = gcc_parent_data_0,
949949
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
950950
.flags = CLK_SET_RATE_PARENT,
951-
.ops = &clk_rcg2_shared_ops,
951+
.ops = &clk_rcg2_ops,
952952
};
953953

954954
static struct clk_rcg2 gcc_qupv3_wrap1_s3_clk_src = {
@@ -980,7 +980,7 @@ static struct clk_init_data gcc_qupv3_wrap1_s4_clk_src_init = {
980980
.parent_data = gcc_parent_data_0,
981981
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
982982
.flags = CLK_SET_RATE_PARENT,
983-
.ops = &clk_rcg2_shared_ops,
983+
.ops = &clk_rcg2_ops,
984984
};
985985

986986
static struct clk_rcg2 gcc_qupv3_wrap1_s4_clk_src = {
@@ -997,7 +997,7 @@ static struct clk_init_data gcc_qupv3_wrap1_s5_clk_src_init = {
997997
.parent_data = gcc_parent_data_0,
998998
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
999999
.flags = CLK_SET_RATE_PARENT,
1000-
.ops = &clk_rcg2_shared_ops,
1000+
.ops = &clk_rcg2_ops,
10011001
};
10021002

10031003
static struct clk_rcg2 gcc_qupv3_wrap1_s5_clk_src = {
@@ -1014,7 +1014,7 @@ static struct clk_init_data gcc_qupv3_wrap1_s6_clk_src_init = {
10141014
.parent_data = gcc_parent_data_0,
10151015
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
10161016
.flags = CLK_SET_RATE_PARENT,
1017-
.ops = &clk_rcg2_shared_ops,
1017+
.ops = &clk_rcg2_ops,
10181018
};
10191019

10201020
static struct clk_rcg2 gcc_qupv3_wrap1_s6_clk_src = {
@@ -1031,7 +1031,7 @@ static struct clk_init_data gcc_qupv3_wrap1_s7_clk_src_init = {
10311031
.parent_data = gcc_parent_data_0,
10321032
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
10331033
.flags = CLK_SET_RATE_PARENT,
1034-
.ops = &clk_rcg2_shared_ops,
1034+
.ops = &clk_rcg2_ops,
10351035
};
10361036

10371037
static struct clk_rcg2 gcc_qupv3_wrap1_s7_clk_src = {
@@ -1059,7 +1059,7 @@ static struct clk_rcg2 gcc_qupv3_wrap2_ibi_ctrl_0_clk_src = {
10591059
.parent_data = gcc_parent_data_2,
10601060
.num_parents = ARRAY_SIZE(gcc_parent_data_2),
10611061
.flags = CLK_SET_RATE_PARENT,
1062-
.ops = &clk_rcg2_shared_ops,
1062+
.ops = &clk_rcg2_ops,
10631063
},
10641064
};
10651065

@@ -1068,7 +1068,7 @@ static struct clk_init_data gcc_qupv3_wrap2_s0_clk_src_init = {
10681068
.parent_data = gcc_parent_data_0,
10691069
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
10701070
.flags = CLK_SET_RATE_PARENT,
1071-
.ops = &clk_rcg2_shared_ops,
1071+
.ops = &clk_rcg2_ops,
10721072
};
10731073

10741074
static struct clk_rcg2 gcc_qupv3_wrap2_s0_clk_src = {
@@ -1085,7 +1085,7 @@ static struct clk_init_data gcc_qupv3_wrap2_s1_clk_src_init = {
10851085
.parent_data = gcc_parent_data_0,
10861086
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
10871087
.flags = CLK_SET_RATE_PARENT,
1088-
.ops = &clk_rcg2_shared_ops,
1088+
.ops = &clk_rcg2_ops,
10891089
};
10901090

10911091
static struct clk_rcg2 gcc_qupv3_wrap2_s1_clk_src = {
@@ -1102,7 +1102,7 @@ static struct clk_init_data gcc_qupv3_wrap2_s2_clk_src_init = {
11021102
.parent_data = gcc_parent_data_0,
11031103
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
11041104
.flags = CLK_SET_RATE_PARENT,
1105-
.ops = &clk_rcg2_shared_ops,
1105+
.ops = &clk_rcg2_ops,
11061106
};
11071107

11081108
static struct clk_rcg2 gcc_qupv3_wrap2_s2_clk_src = {
@@ -1119,7 +1119,7 @@ static struct clk_init_data gcc_qupv3_wrap2_s3_clk_src_init = {
11191119
.parent_data = gcc_parent_data_0,
11201120
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
11211121
.flags = CLK_SET_RATE_PARENT,
1122-
.ops = &clk_rcg2_shared_ops,
1122+
.ops = &clk_rcg2_ops,
11231123
};
11241124

11251125
static struct clk_rcg2 gcc_qupv3_wrap2_s3_clk_src = {
@@ -1136,7 +1136,7 @@ static struct clk_init_data gcc_qupv3_wrap2_s4_clk_src_init = {
11361136
.parent_data = gcc_parent_data_0,
11371137
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
11381138
.flags = CLK_SET_RATE_PARENT,
1139-
.ops = &clk_rcg2_shared_ops,
1139+
.ops = &clk_rcg2_ops,
11401140
};
11411141

11421142
static struct clk_rcg2 gcc_qupv3_wrap2_s4_clk_src = {
@@ -1153,7 +1153,7 @@ static struct clk_init_data gcc_qupv3_wrap2_s5_clk_src_init = {
11531153
.parent_data = gcc_parent_data_0,
11541154
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
11551155
.flags = CLK_SET_RATE_PARENT,
1156-
.ops = &clk_rcg2_shared_ops,
1156+
.ops = &clk_rcg2_ops,
11571157
};
11581158

11591159
static struct clk_rcg2 gcc_qupv3_wrap2_s5_clk_src = {
@@ -1186,7 +1186,7 @@ static struct clk_init_data gcc_qupv3_wrap2_s6_clk_src_init = {
11861186
.parent_data = gcc_parent_data_10,
11871187
.num_parents = ARRAY_SIZE(gcc_parent_data_10),
11881188
.flags = CLK_SET_RATE_PARENT,
1189-
.ops = &clk_rcg2_shared_ops,
1189+
.ops = &clk_rcg2_ops,
11901190
};
11911191

11921192
static struct clk_rcg2 gcc_qupv3_wrap2_s6_clk_src = {
@@ -1203,7 +1203,7 @@ static struct clk_init_data gcc_qupv3_wrap2_s7_clk_src_init = {
12031203
.parent_data = gcc_parent_data_0,
12041204
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
12051205
.flags = CLK_SET_RATE_PARENT,
1206-
.ops = &clk_rcg2_shared_ops,
1206+
.ops = &clk_rcg2_ops,
12071207
};
12081208

12091209
static struct clk_rcg2 gcc_qupv3_wrap2_s7_clk_src = {
@@ -1226,7 +1226,7 @@ static struct clk_init_data gcc_qupv3_wrap3_qspi_ref_clk_src_init = {
12261226
.parent_data = gcc_parent_data_0,
12271227
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
12281228
.flags = CLK_SET_RATE_PARENT,
1229-
.ops = &clk_rcg2_shared_ops,
1229+
.ops = &clk_rcg2_ops,
12301230
};
12311231

12321232
static struct clk_rcg2 gcc_qupv3_wrap3_qspi_ref_clk_src = {

0 commit comments

Comments
 (0)