Skip to content

Commit a9ba290

Browse files
Mani-Sadhasivamvireshk
authored andcommitted
cpufreq: qcom: Implement clk_ops::determine_rate() for qcom_cpufreq* clocks
determine_rate() callback is used by the clk_set_rate() API to get the closest rate of the target rate supported by the clock. If this callback is not implemented (nor round_rate() callback), then the API will assume that the clock cannot set the requested rate. And since there is no parent, it will return -EINVAL. This is not an issue right now as clk_set_rate() mistakenly compares the target rate with cached rate and bails out early. But once that is fixed to compare the target rate with the actual rate of the clock (returned by recalc_rate()), then clk_set_rate() for this clock will start to fail as below: cpu cpu0: _opp_config_clk_single: failed to set clock rate: -22 So implement the determine_rate() callback that just returns the actual rate at which the clock is passed to the CPUs in a domain. Fixes: 4370232 ("cpufreq: qcom-hw: Add CPU clock provider support") Reported-by: Johan Hovold <johan+linaro@kernel.org> Suggested-by: Stephen Boyd <sboyd@kernel.org> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Reviewed-by: Stephen Boyd <sboyd@kernel.org> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
1 parent 85d8b11 commit a9ba290

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

drivers/cpufreq/qcom-cpufreq-hw.c

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -626,8 +626,21 @@ static unsigned long qcom_cpufreq_hw_recalc_rate(struct clk_hw *hw, unsigned lon
626626
return __qcom_cpufreq_hw_get(data->policy) * HZ_PER_KHZ;
627627
}
628628

629+
/*
630+
* Since we cannot determine the closest rate of the target rate, let's just
631+
* return the actual rate at which the clock is running at. This is needed to
632+
* make clk_set_rate() API work properly.
633+
*/
634+
static int qcom_cpufreq_hw_determine_rate(struct clk_hw *hw, struct clk_rate_request *req)
635+
{
636+
req->rate = qcom_cpufreq_hw_recalc_rate(hw, 0);
637+
638+
return 0;
639+
}
640+
629641
static const struct clk_ops qcom_cpufreq_hw_clk_ops = {
630642
.recalc_rate = qcom_cpufreq_hw_recalc_rate,
643+
.determine_rate = qcom_cpufreq_hw_determine_rate,
631644
};
632645

633646
static int qcom_cpufreq_hw_driver_probe(struct platform_device *pdev)

0 commit comments

Comments
 (0)