Skip to content

Commit a86c6d0

Browse files
committed
Merge tag 'fscrypt-for-linus' of git://git.kernel.org/pub/scm/fs/fscrypt/linux
Pull fscrypt updates from Eric Biggers: "A fix for an issue where CONFIG_FS_ENCRYPTION could be enabled without some of its dependencies, and a small documentation update" * tag 'fscrypt-for-linus' of git://git.kernel.org/pub/scm/fs/fscrypt/linux: fscrypt: mention init_on_free instead of page poisoning fscrypt: drop obsolete recommendation to enable optimized ChaCha20 Revert "fscrypt: relax Kconfig dependencies for crypto API algorithms"
2 parents bdab297 + 13dc8eb commit a86c6d0

File tree

2 files changed

+10
-18
lines changed

2 files changed

+10
-18
lines changed

Documentation/filesystems/fscrypt.rst

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,8 @@ However, these ioctls have some limitations:
137137
- In general, decrypted contents and filenames in the kernel VFS
138138
caches are freed but not wiped. Therefore, portions thereof may be
139139
recoverable from freed memory, even after the corresponding key(s)
140-
were wiped. To partially solve this, you can set
141-
CONFIG_PAGE_POISONING=y in your kernel config and add page_poison=1
142-
to your kernel command line. However, this has a performance cost.
140+
were wiped. To partially solve this, you can add init_on_free=1 to
141+
your kernel command line. However, this has a performance cost.
143142

144143
- Secret keys might still exist in CPU registers, in crypto
145144
accelerator hardware (if used by the crypto API to implement any of
@@ -428,11 +427,8 @@ API, but the filenames mode still does.
428427
- Mandatory:
429428
- CONFIG_CRYPTO_ADIANTUM
430429
- Recommended:
431-
- arm32: CONFIG_CRYPTO_CHACHA20_NEON
432430
- arm32: CONFIG_CRYPTO_NHPOLY1305_NEON
433-
- arm64: CONFIG_CRYPTO_CHACHA20_NEON
434431
- arm64: CONFIG_CRYPTO_NHPOLY1305_NEON
435-
- x86: CONFIG_CRYPTO_CHACHA20_X86_64
436432
- x86: CONFIG_CRYPTO_NHPOLY1305_SSE2
437433
- x86: CONFIG_CRYPTO_NHPOLY1305_AVX2
438434

fs/crypto/Kconfig

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,20 +24,16 @@ config FS_ENCRYPTION
2424
#
2525
# Also note that this option only pulls in the generic implementations of the
2626
# algorithms, not any per-architecture optimized implementations. It is
27-
# strongly recommended to enable optimized implementations too. It is safe to
28-
# disable these generic implementations if corresponding optimized
29-
# implementations will always be available too; for this reason, these are soft
30-
# dependencies ('imply' rather than 'select'). Only disable these generic
31-
# implementations if you're sure they will never be needed, though.
27+
# strongly recommended to enable optimized implementations too.
3228
config FS_ENCRYPTION_ALGS
3329
tristate
34-
imply CRYPTO_AES
35-
imply CRYPTO_CBC
36-
imply CRYPTO_CTS
37-
imply CRYPTO_ECB
38-
imply CRYPTO_HMAC
39-
imply CRYPTO_SHA512
40-
imply CRYPTO_XTS
30+
select CRYPTO_AES
31+
select CRYPTO_CBC
32+
select CRYPTO_CTS
33+
select CRYPTO_ECB
34+
select CRYPTO_HMAC
35+
select CRYPTO_SHA512
36+
select CRYPTO_XTS
4137

4238
config FS_ENCRYPTION_INLINE_CRYPT
4339
bool "Enable fscrypt to use inline crypto"

0 commit comments

Comments
 (0)