Skip to content

Commit a53da2f

Browse files
johnharr-intelThomas Hellström
authored andcommitted
drm/xe: Revert some changes that break a mesa debug tool
There is a mesa debug tool for decoding devcoredump files. Recent changes to improve the devcoredump output broke that tool. So revert the changes until the tool can be extended to support the new fields. Signed-off-by: John Harrison <John.C.Harrison@Intel.com> Fixes: c28fd6c ("drm/xe/devcoredump: Improve section headings and add tile info") Fixes: ec1455c ("drm/xe/devcoredump: Add ASCII85 dump helper function") Cc: John Harrison <John.C.Harrison@Intel.com> Cc: Julia Filipchuk <julia.filipchuk@intel.com> Cc: Lucas De Marchi <lucas.demarchi@intel.com> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: intel-xe@lists.freedesktop.org Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com> Reviewed-by: José Roberto de Souza <jose.souza@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20241213172833.1733376-1-John.C.Harrison@Intel.com Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> (cherry picked from commit 70fb86a) Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
1 parent 4bbf902 commit a53da2f

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

drivers/gpu/drm/xe/xe_devcoredump.c

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,11 @@ static ssize_t __xe_devcoredump_read(char *buffer, size_t count,
109109
drm_puts(&p, "\n**** GuC CT ****\n");
110110
xe_guc_ct_snapshot_print(ss->guc.ct, &p);
111111

112-
drm_puts(&p, "\n**** Contexts ****\n");
112+
/*
113+
* Don't add a new section header here because the mesa debug decoder
114+
* tool expects the context information to be in the 'GuC CT' section.
115+
*/
116+
/* drm_puts(&p, "\n**** Contexts ****\n"); */
113117
xe_guc_exec_queue_snapshot_print(ss->ge, &p);
114118

115119
drm_puts(&p, "\n**** Job ****\n");
@@ -363,6 +367,15 @@ void xe_print_blob_ascii85(struct drm_printer *p, const char *prefix,
363367
char buff[ASCII85_BUFSZ], *line_buff;
364368
size_t line_pos = 0;
365369

370+
/*
371+
* Splitting blobs across multiple lines is not compatible with the mesa
372+
* debug decoder tool. Note that even dropping the explicit '\n' below
373+
* doesn't help because the GuC log is so big some underlying implementation
374+
* still splits the lines at 512K characters. So just bail completely for
375+
* the moment.
376+
*/
377+
return;
378+
366379
#define DMESG_MAX_LINE_LEN 800
367380
#define MIN_SPACE (ASCII85_BUFSZ + 2) /* 85 + "\n\0" */
368381

0 commit comments

Comments
 (0)