Skip to content

Commit a1d8f70

Browse files
Dan Carpenterbroonie
authored andcommitted
spi: sg2044-nor: fix uninitialized variable in probe
The "base" pointer is uninitialized. It should be "spifmc->io_base" instead. Fixes: de16c32 ("spi: sophgo: add SG2044 SPI NOR controller driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> Link: https://patch.msgid.link/d343921b-16b8-429b-888a-f51bb6f2edc8@stanley.mountain Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 16c6cac commit a1d8f70

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/spi/spi-sg2044-nor.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,6 @@ static int sg2044_spifmc_probe(struct platform_device *pdev)
427427
{
428428
struct spi_controller *ctrl;
429429
struct sg2044_spifmc *spifmc;
430-
void __iomem *base;
431430
int ret;
432431

433432
ctrl = devm_spi_alloc_host(&pdev->dev, sizeof(*spifmc));
@@ -447,8 +446,8 @@ static int sg2044_spifmc_probe(struct platform_device *pdev)
447446
spifmc->ctrl = ctrl;
448447

449448
spifmc->io_base = devm_platform_ioremap_resource(pdev, 0);
450-
if (IS_ERR(base))
451-
return PTR_ERR(base);
449+
if (IS_ERR(spifmc->io_base))
450+
return PTR_ERR(spifmc->io_base);
452451

453452
ctrl->num_chipselect = 1;
454453
ctrl->dev.of_node = pdev->dev.of_node;

0 commit comments

Comments
 (0)