Skip to content

Commit a00e197

Browse files
Prashanth Kgregkh
authored andcommitted
usb: typec: ucsi: Clear EVENT_PENDING bit if ucsi_send_command fails
Currently if ucsi_send_command() fails, then we bail out without clearing EVENT_PENDING flag. So when the next connector change event comes, ucsi_connector_change() won't queue the con->work, because of which none of the new events will be processed. Fix this by clearing EVENT_PENDING flag if ucsi_send_command() fails. Cc: stable@vger.kernel.org # 5.16 Fixes: 512df95 ("usb: typec: ucsi: Better fix for missing unplug events issue") Signed-off-by: Prashanth K <quic_prashk@quicinc.com> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Link: https://lore.kernel.org/r/1694423055-8440-1-git-send-email-quic_prashk@quicinc.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent e59e381 commit a00e197

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/usb/typec/ucsi/ucsi.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -884,6 +884,7 @@ static void ucsi_handle_connector_change(struct work_struct *work)
884884
if (ret < 0) {
885885
dev_err(ucsi->dev, "%s: GET_CONNECTOR_STATUS failed (%d)\n",
886886
__func__, ret);
887+
clear_bit(EVENT_PENDING, &con->ucsi->flags);
887888
goto out_unlock;
888889
}
889890

0 commit comments

Comments
 (0)