Skip to content

Commit 9efefa1

Browse files
Robert Richterdavejiang
authored andcommitted
cxl/region: Add a dev_warn() on registration failure
Esp. in complex system configurations with multiple endpoints and interleaving setups it is hard to detect region setup failures as its registration may silently fail. Add messages to show registration failures. Example log message: cxl region5: region sort successful cxl region5: mem0:endpoint5 decoder5.0 add: mem0:decoder5.0 @ 0 next: none nr_eps: 1 nr_targets: 1 cxl_port endpoint5: decoder5.0: range: 0x22350000000-0x2634fffffff iw: 1 ig: 256 cxl region5: pci0000:e0:port1 decoder1.2 add: mem0:decoder5.0 @ 0 next: mem0 nr_eps: 1 nr_targets: 1 cxl region5: pci0000:e0:port1 iw: 1 ig: 256 cxl region5: pci0000:e0:port1: decoder1.2 expected 0000:e0:01.2 at 0 cxl endpoint5: failed to attach decoder5.0 to region5: -6 cxl_port endpoint5: probe: 0 Signed-off-by: Robert Richter <rrichter@amd.com> Reviewed-by: Gregory Price <gourry@gourry.net> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Reviewed-by: Dan Williams <dan.j.williams@intel.com> Reviewed-by: Alison Schofield <alison.schofield@intel.com> Reviewed-by: "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com> Tested-by: Gregory Price <gourry@gourry.net> Acked-by: Dan Williams <dan.j.williams@intel.com> Link: https://patch.msgid.link/20250509150700.2817697-13-rrichter@amd.com Signed-off-by: Dave Jiang <dave.jiang@intel.com>
1 parent d6879d8 commit 9efefa1

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

drivers/cxl/core/region.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2166,6 +2166,12 @@ static int attach_target(struct cxl_region *cxlr,
21662166
rc = cxl_region_attach(cxlr, cxled, pos);
21672167
up_read(&cxl_dpa_rwsem);
21682168
up_write(&cxl_region_rwsem);
2169+
2170+
if (rc)
2171+
dev_warn(cxled->cxld.dev.parent,
2172+
"failed to attach %s to %s: %d\n",
2173+
dev_name(&cxled->cxld.dev), dev_name(&cxlr->dev), rc);
2174+
21692175
return rc;
21702176
}
21712177

0 commit comments

Comments
 (0)