Skip to content

Commit 9cfdd77

Browse files
nfrapradobroonie
authored andcommitted
regulator: dt-bindings: mt6357: Drop fixed compatible requirement
Some of the regulators on the MT6357 PMIC currently reference the fixed-regulator dt-binding, which enforces the presence of a regulator-fixed compatible. However since all regulators on the MT6357 PMIC are handled by a single mt6357-regulator driver, probed through MFD, the compatibles don't serve any purpose. In fact they cause failures in the DT kselftest since they aren't probed by the fixed regulator driver as would be expected. Furthermore this is the only dt-binding in this family like this: mt6359-regulator and mt6358-regulator don't require those compatibles. Commit d77e89b ("arm64: dts: mediatek: mt6357: Drop regulator-fixed compatibles") removed the compatibles from Devicetree, but missed updating the binding, which still requires them, introducing dt-binding errors. Remove the compatible requirement by referencing the plain regulator dt-binding instead to fix the dt-binding errors. Fixes: d77e89b ("arm64: dts: mediatek: mt6357: Drop regulator-fixed compatibles") Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Link: https://patch.msgid.link/20250514-mt6357-regulator-fixed-compatibles-removal-bindings-v1-1-2421e9cc6cc7@collabora.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent cad915e commit 9cfdd77

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

Documentation/devicetree/bindings/regulator/mediatek,mt6357-regulator.yaml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ patternProperties:
3333

3434
"^ldo-v(camio18|aud28|aux18|io18|io28|rf12|rf18|cn18|cn28|fe28)$":
3535
type: object
36-
$ref: fixed-regulator.yaml#
36+
$ref: regulator.yaml#
3737
unevaluatedProperties: false
3838
description:
3939
Properties for single fixed LDO regulator.
@@ -112,7 +112,6 @@ examples:
112112
regulator-enable-ramp-delay = <220>;
113113
};
114114
mt6357_vfe28_reg: ldo-vfe28 {
115-
compatible = "regulator-fixed";
116115
regulator-name = "vfe28";
117116
regulator-min-microvolt = <2800000>;
118117
regulator-max-microvolt = <2800000>;
@@ -125,14 +124,12 @@ examples:
125124
regulator-enable-ramp-delay = <110>;
126125
};
127126
mt6357_vrf18_reg: ldo-vrf18 {
128-
compatible = "regulator-fixed";
129127
regulator-name = "vrf18";
130128
regulator-min-microvolt = <1800000>;
131129
regulator-max-microvolt = <1800000>;
132130
regulator-enable-ramp-delay = <110>;
133131
};
134132
mt6357_vrf12_reg: ldo-vrf12 {
135-
compatible = "regulator-fixed";
136133
regulator-name = "vrf12";
137134
regulator-min-microvolt = <1200000>;
138135
regulator-max-microvolt = <1200000>;
@@ -157,14 +154,12 @@ examples:
157154
regulator-enable-ramp-delay = <264>;
158155
};
159156
mt6357_vcn28_reg: ldo-vcn28 {
160-
compatible = "regulator-fixed";
161157
regulator-name = "vcn28";
162158
regulator-min-microvolt = <2800000>;
163159
regulator-max-microvolt = <2800000>;
164160
regulator-enable-ramp-delay = <264>;
165161
};
166162
mt6357_vcn18_reg: ldo-vcn18 {
167-
compatible = "regulator-fixed";
168163
regulator-name = "vcn18";
169164
regulator-min-microvolt = <1800000>;
170165
regulator-max-microvolt = <1800000>;
@@ -183,7 +178,6 @@ examples:
183178
regulator-enable-ramp-delay = <264>;
184179
};
185180
mt6357_vcamio_reg: ldo-vcamio18 {
186-
compatible = "regulator-fixed";
187181
regulator-name = "vcamio";
188182
regulator-min-microvolt = <1800000>;
189183
regulator-max-microvolt = <1800000>;
@@ -212,28 +206,24 @@ examples:
212206
regulator-always-on;
213207
};
214208
mt6357_vaux18_reg: ldo-vaux18 {
215-
compatible = "regulator-fixed";
216209
regulator-name = "vaux18";
217210
regulator-min-microvolt = <1800000>;
218211
regulator-max-microvolt = <1800000>;
219212
regulator-enable-ramp-delay = <264>;
220213
};
221214
mt6357_vaud28_reg: ldo-vaud28 {
222-
compatible = "regulator-fixed";
223215
regulator-name = "vaud28";
224216
regulator-min-microvolt = <2800000>;
225217
regulator-max-microvolt = <2800000>;
226218
regulator-enable-ramp-delay = <264>;
227219
};
228220
mt6357_vio28_reg: ldo-vio28 {
229-
compatible = "regulator-fixed";
230221
regulator-name = "vio28";
231222
regulator-min-microvolt = <2800000>;
232223
regulator-max-microvolt = <2800000>;
233224
regulator-enable-ramp-delay = <264>;
234225
};
235226
mt6357_vio18_reg: ldo-vio18 {
236-
compatible = "regulator-fixed";
237227
regulator-name = "vio18";
238228
regulator-min-microvolt = <1800000>;
239229
regulator-max-microvolt = <1800000>;

0 commit comments

Comments
 (0)