fbdev: sisfb: Fix strbuf array overflow

Andrey Shumilin · hdeller · commit 9cf14f5a2746 · 2024-09-28T00:42:11.000+02:00
The values of the variables xres and yres are placed in strbuf.
These variables are obtained from strbuf1.
The strbuf1 array contains digit characters
and a space if the array contains non-digit characters.
Then, when executing sprintf(strbuf, "%ux%ux8", xres, yres);
more than 16 bytes will be written to strbuf.
It is suggested to increase the size of the strbuf array to 24.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Andrey Shumilin &lt;shum.sdl@nppct.ru&gt;
Signed-off-by: Helge Deller &lt;deller@gmx.de&gt;
diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
@@ -183,7 +183,7 @@ static void sisfb_search_mode(char *name, bool quiet)
 {
 	unsigned int j = 0, xres = 0, yres = 0, depth = 0, rate = 0;
 	int i = 0;
-	char strbuf[16], strbuf1[20];
+	char strbuf[24], strbuf1[20];
 	char *nameptr = name;
 
 	/* We don't know the hardware specs yet and there is no ivideo */

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ static void sisfb_search_mode(char *name, bool quiet)`
`183`	`183`	`{`
`184`	`184`	`unsigned int j = 0, xres = 0, yres = 0, depth = 0, rate = 0;`
`185`	`185`	`int i = 0;`
`186`		`- char strbuf[16], strbuf1[20];`
	`186`	`+ char strbuf[24], strbuf1[20];`
`187`	`187`	`char *nameptr = name;`
`188`	`188`
`189`	`189`	`/* We don't know the hardware specs yet and there is no ivideo */`