Skip to content

Commit 987ce79

Browse files
rddunlaphtejun
authored andcommitted
sched_ext: fix kernel-doc warnings
Use the correct function parameter names and function names. Use the correct kernel-doc comment format for struct sched_ext_ops to eliminate a bunch of warnings. ext.c:1418: warning: Excess function parameter 'include_dead' description in 'scx_task_iter_next_locked' ext.c:7261: warning: expecting prototype for scx_bpf_dump(). Prototype was for scx_bpf_dump_bstr() instead ext.c:7352: warning: Excess function parameter 'flags' description in 'scx_bpf_cpuperf_set' ext.c:3150: warning: Function parameter or struct member 'in_fi' not described in 'scx_prio_less' ext.c:4711: warning: Function parameter or struct member 'dur_s' not described in 'scx_softlockup' ext.c:4775: warning: Function parameter or struct member 'bypass' not described in 'scx_ops_bypass' ext.c:7453: warning: Function parameter or struct member 'idle_mask' not described in 'scx_bpf_put_idle_cpumask' ext.c:209: warning: Incorrect use of kernel-doc format: * select_cpu - Pick the target CPU for a task which is being woken up ext.c:236: warning: Incorrect use of kernel-doc format: * enqueue - Enqueue a task on the BPF scheduler ext.c:251: warning: Incorrect use of kernel-doc format: * dequeue - Remove a task from the BPF scheduler ext.c:267: warning: Incorrect use of kernel-doc format: * dispatch - Dispatch tasks from the BPF scheduler and/or user DSQs ext.c:290: warning: Incorrect use of kernel-doc format: * tick - Periodic tick ext.c:300: warning: Incorrect use of kernel-doc format: * runnable - A task is becoming runnable on its associated CPU ext.c:327: warning: Incorrect use of kernel-doc format: * running - A task is starting to run on its associated CPU ext.c:335: warning: Incorrect use of kernel-doc format: * stopping - A task is stopping execution ext.c:346: warning: Incorrect use of kernel-doc format: * quiescent - A task is becoming not runnable on its associated CPU ext.c:366: warning: Incorrect use of kernel-doc format: * yield - Yield CPU ext.c:381: warning: Incorrect use of kernel-doc format: * core_sched_before - Task ordering for core-sched ext.c:399: warning: Incorrect use of kernel-doc format: * set_weight - Set task weight ext.c:408: warning: Incorrect use of kernel-doc format: * set_cpumask - Set CPU affinity ext.c:418: warning: Incorrect use of kernel-doc format: * update_idle - Update the idle state of a CPU ext.c:439: warning: Incorrect use of kernel-doc format: * cpu_acquire - A CPU is becoming available to the BPF scheduler ext.c:449: warning: Incorrect use of kernel-doc format: * cpu_release - A CPU is taken away from the BPF scheduler ext.c:461: warning: Incorrect use of kernel-doc format: * init_task - Initialize a task to run in a BPF scheduler ext.c:476: warning: Incorrect use of kernel-doc format: * exit_task - Exit a previously-running task from the system ext.c:485: warning: Incorrect use of kernel-doc format: * enable - Enable BPF scheduling for a task ext.c:494: warning: Incorrect use of kernel-doc format: * disable - Disable BPF scheduling for a task ext.c:504: warning: Incorrect use of kernel-doc format: * dump - Dump BPF scheduler state on error ext.c:512: warning: Incorrect use of kernel-doc format: * dump_cpu - Dump BPF scheduler state for a CPU on error ext.c:524: warning: Incorrect use of kernel-doc format: * dump_task - Dump BPF scheduler state for a runnable task on error ext.c:535: warning: Incorrect use of kernel-doc format: * cgroup_init - Initialize a cgroup ext.c:550: warning: Incorrect use of kernel-doc format: * cgroup_exit - Exit a cgroup ext.c:559: warning: Incorrect use of kernel-doc format: * cgroup_prep_move - Prepare a task to be moved to a different cgroup ext.c:574: warning: Incorrect use of kernel-doc format: * cgroup_move - Commit cgroup move ext.c:585: warning: Incorrect use of kernel-doc format: * cgroup_cancel_move - Cancel cgroup move ext.c:597: warning: Incorrect use of kernel-doc format: * cgroup_set_weight - A cgroup's weight is being changed ext.c:611: warning: Incorrect use of kernel-doc format: * cpu_online - A CPU became online ext.c:620: warning: Incorrect use of kernel-doc format: * cpu_offline - A CPU is going offline ext.c:633: warning: Incorrect use of kernel-doc format: * init - Initialize the BPF scheduler ext.c:638: warning: Incorrect use of kernel-doc format: * exit - Clean up after the BPF scheduler ext.c:648: warning: Incorrect use of kernel-doc format: * dispatch_max_batch - Max nr of tasks that dispatch() can dispatch ext.c:653: warning: Incorrect use of kernel-doc format: * flags - %SCX_OPS_* flags ext.c:658: warning: Incorrect use of kernel-doc format: * timeout_ms - The maximum amount of time, in milliseconds, that a ext.c:667: warning: Incorrect use of kernel-doc format: * exit_dump_len - scx_exit_info.dump buffer length. If 0, the default ext.c:673: warning: Incorrect use of kernel-doc format: * hotplug_seq - A sequence number that may be set by the scheduler to ext.c:682: warning: Incorrect use of kernel-doc format: * name - BPF scheduler's name ext.c:689: warning: Function parameter or struct member 'select_cpu' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'enqueue' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'dequeue' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'dispatch' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'tick' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'runnable' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'running' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'stopping' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'quiescent' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'yield' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'core_sched_before' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'set_weight' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'set_cpumask' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'update_idle' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'cpu_acquire' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'cpu_release' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'init_task' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'exit_task' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'enable' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'disable' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'dump' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'dump_cpu' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'dump_task' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'cgroup_init' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'cgroup_exit' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'cgroup_prep_move' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'cgroup_move' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'cgroup_cancel_move' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'cgroup_set_weight' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'cpu_online' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'cpu_offline' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'init' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'exit' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'dispatch_max_batch' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'flags' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'timeout_ms' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'exit_dump_len' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'hotplug_seq' not described in 'sched_ext_ops' ext.c:689: warning: Function parameter or struct member 'name' not described in 'sched_ext_ops' Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Tejun Heo <tj@kernel.org> Cc: David Vernet <void@manifault.com> Cc: Changwoo Min <changwoo@igalia.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: bpf@vger.kernel.org Acked-by: Andrea Righi <arighi@nvidia.com> Signed-off-by: Tejun Heo <tj@kernel.org>
1 parent 62addc6 commit 987ce79

File tree

1 file changed

+45
-42
lines changed

1 file changed

+45
-42
lines changed

kernel/sched/ext.c

Lines changed: 45 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ struct scx_dump_ctx {
206206
*/
207207
struct sched_ext_ops {
208208
/**
209-
* select_cpu - Pick the target CPU for a task which is being woken up
209+
* @select_cpu: Pick the target CPU for a task which is being woken up
210210
* @p: task being woken up
211211
* @prev_cpu: the cpu @p was on before sleeping
212212
* @wake_flags: SCX_WAKE_*
@@ -233,7 +233,7 @@ struct sched_ext_ops {
233233
s32 (*select_cpu)(struct task_struct *p, s32 prev_cpu, u64 wake_flags);
234234

235235
/**
236-
* enqueue - Enqueue a task on the BPF scheduler
236+
* @enqueue: Enqueue a task on the BPF scheduler
237237
* @p: task being enqueued
238238
* @enq_flags: %SCX_ENQ_*
239239
*
@@ -248,7 +248,7 @@ struct sched_ext_ops {
248248
void (*enqueue)(struct task_struct *p, u64 enq_flags);
249249

250250
/**
251-
* dequeue - Remove a task from the BPF scheduler
251+
* @dequeue: Remove a task from the BPF scheduler
252252
* @p: task being dequeued
253253
* @deq_flags: %SCX_DEQ_*
254254
*
@@ -264,7 +264,7 @@ struct sched_ext_ops {
264264
void (*dequeue)(struct task_struct *p, u64 deq_flags);
265265

266266
/**
267-
* dispatch - Dispatch tasks from the BPF scheduler and/or user DSQs
267+
* @dispatch: Dispatch tasks from the BPF scheduler and/or user DSQs
268268
* @cpu: CPU to dispatch tasks for
269269
* @prev: previous task being switched out
270270
*
@@ -287,7 +287,7 @@ struct sched_ext_ops {
287287
void (*dispatch)(s32 cpu, struct task_struct *prev);
288288

289289
/**
290-
* tick - Periodic tick
290+
* @tick: Periodic tick
291291
* @p: task running currently
292292
*
293293
* This operation is called every 1/HZ seconds on CPUs which are
@@ -297,7 +297,7 @@ struct sched_ext_ops {
297297
void (*tick)(struct task_struct *p);
298298

299299
/**
300-
* runnable - A task is becoming runnable on its associated CPU
300+
* @runnable: A task is becoming runnable on its associated CPU
301301
* @p: task becoming runnable
302302
* @enq_flags: %SCX_ENQ_*
303303
*
@@ -324,15 +324,15 @@ struct sched_ext_ops {
324324
void (*runnable)(struct task_struct *p, u64 enq_flags);
325325

326326
/**
327-
* running - A task is starting to run on its associated CPU
327+
* @running: A task is starting to run on its associated CPU
328328
* @p: task starting to run
329329
*
330330
* See ->runnable() for explanation on the task state notifiers.
331331
*/
332332
void (*running)(struct task_struct *p);
333333

334334
/**
335-
* stopping - A task is stopping execution
335+
* @stopping: A task is stopping execution
336336
* @p: task stopping to run
337337
* @runnable: is task @p still runnable?
338338
*
@@ -343,7 +343,7 @@ struct sched_ext_ops {
343343
void (*stopping)(struct task_struct *p, bool runnable);
344344

345345
/**
346-
* quiescent - A task is becoming not runnable on its associated CPU
346+
* @quiescent: A task is becoming not runnable on its associated CPU
347347
* @p: task becoming not runnable
348348
* @deq_flags: %SCX_DEQ_*
349349
*
@@ -363,7 +363,7 @@ struct sched_ext_ops {
363363
void (*quiescent)(struct task_struct *p, u64 deq_flags);
364364

365365
/**
366-
* yield - Yield CPU
366+
* @yield: Yield CPU
367367
* @from: yielding task
368368
* @to: optional yield target task
369369
*
@@ -378,7 +378,7 @@ struct sched_ext_ops {
378378
bool (*yield)(struct task_struct *from, struct task_struct *to);
379379

380380
/**
381-
* core_sched_before - Task ordering for core-sched
381+
* @core_sched_before: Task ordering for core-sched
382382
* @a: task A
383383
* @b: task B
384384
*
@@ -396,7 +396,7 @@ struct sched_ext_ops {
396396
bool (*core_sched_before)(struct task_struct *a, struct task_struct *b);
397397

398398
/**
399-
* set_weight - Set task weight
399+
* @set_weight: Set task weight
400400
* @p: task to set weight for
401401
* @weight: new weight [1..10000]
402402
*
@@ -405,7 +405,7 @@ struct sched_ext_ops {
405405
void (*set_weight)(struct task_struct *p, u32 weight);
406406

407407
/**
408-
* set_cpumask - Set CPU affinity
408+
* @set_cpumask: Set CPU affinity
409409
* @p: task to set CPU affinity for
410410
* @cpumask: cpumask of cpus that @p can run on
411411
*
@@ -415,7 +415,7 @@ struct sched_ext_ops {
415415
const struct cpumask *cpumask);
416416

417417
/**
418-
* update_idle - Update the idle state of a CPU
418+
* @update_idle: Update the idle state of a CPU
419419
* @cpu: CPU to udpate the idle state for
420420
* @idle: whether entering or exiting the idle state
421421
*
@@ -436,7 +436,7 @@ struct sched_ext_ops {
436436
void (*update_idle)(s32 cpu, bool idle);
437437

438438
/**
439-
* cpu_acquire - A CPU is becoming available to the BPF scheduler
439+
* @cpu_acquire: A CPU is becoming available to the BPF scheduler
440440
* @cpu: The CPU being acquired by the BPF scheduler.
441441
* @args: Acquire arguments, see the struct definition.
442442
*
@@ -446,7 +446,7 @@ struct sched_ext_ops {
446446
void (*cpu_acquire)(s32 cpu, struct scx_cpu_acquire_args *args);
447447

448448
/**
449-
* cpu_release - A CPU is taken away from the BPF scheduler
449+
* @cpu_release: A CPU is taken away from the BPF scheduler
450450
* @cpu: The CPU being released by the BPF scheduler.
451451
* @args: Release arguments, see the struct definition.
452452
*
@@ -458,7 +458,7 @@ struct sched_ext_ops {
458458
void (*cpu_release)(s32 cpu, struct scx_cpu_release_args *args);
459459

460460
/**
461-
* init_task - Initialize a task to run in a BPF scheduler
461+
* @init_task: Initialize a task to run in a BPF scheduler
462462
* @p: task to initialize for BPF scheduling
463463
* @args: init arguments, see the struct definition
464464
*
@@ -473,16 +473,17 @@ struct sched_ext_ops {
473473
s32 (*init_task)(struct task_struct *p, struct scx_init_task_args *args);
474474

475475
/**
476-
* exit_task - Exit a previously-running task from the system
476+
* @exit_task: Exit a previously-running task from the system
477477
* @p: task to exit
478+
* @args: exit arguments, see the struct definition
478479
*
479480
* @p is exiting or the BPF scheduler is being unloaded. Perform any
480481
* necessary cleanup for @p.
481482
*/
482483
void (*exit_task)(struct task_struct *p, struct scx_exit_task_args *args);
483484

484485
/**
485-
* enable - Enable BPF scheduling for a task
486+
* @enable: Enable BPF scheduling for a task
486487
* @p: task to enable BPF scheduling for
487488
*
488489
* Enable @p for BPF scheduling. enable() is called on @p any time it
@@ -491,7 +492,7 @@ struct sched_ext_ops {
491492
void (*enable)(struct task_struct *p);
492493

493494
/**
494-
* disable - Disable BPF scheduling for a task
495+
* @disable: Disable BPF scheduling for a task
495496
* @p: task to disable BPF scheduling for
496497
*
497498
* @p is exiting, leaving SCX or the BPF scheduler is being unloaded.
@@ -501,15 +502,15 @@ struct sched_ext_ops {
501502
void (*disable)(struct task_struct *p);
502503

503504
/**
504-
* dump - Dump BPF scheduler state on error
505+
* @dump: Dump BPF scheduler state on error
505506
* @ctx: debug dump context
506507
*
507508
* Use scx_bpf_dump() to generate BPF scheduler specific debug dump.
508509
*/
509510
void (*dump)(struct scx_dump_ctx *ctx);
510511

511512
/**
512-
* dump_cpu - Dump BPF scheduler state for a CPU on error
513+
* @dump_cpu: Dump BPF scheduler state for a CPU on error
513514
* @ctx: debug dump context
514515
* @cpu: CPU to generate debug dump for
515516
* @idle: @cpu is currently idle without any runnable tasks
@@ -521,7 +522,7 @@ struct sched_ext_ops {
521522
void (*dump_cpu)(struct scx_dump_ctx *ctx, s32 cpu, bool idle);
522523

523524
/**
524-
* dump_task - Dump BPF scheduler state for a runnable task on error
525+
* @dump_task: Dump BPF scheduler state for a runnable task on error
525526
* @ctx: debug dump context
526527
* @p: runnable task to generate debug dump for
527528
*
@@ -532,7 +533,7 @@ struct sched_ext_ops {
532533

533534
#ifdef CONFIG_EXT_GROUP_SCHED
534535
/**
535-
* cgroup_init - Initialize a cgroup
536+
* @cgroup_init: Initialize a cgroup
536537
* @cgrp: cgroup being initialized
537538
* @args: init arguments, see the struct definition
538539
*
@@ -547,7 +548,7 @@ struct sched_ext_ops {
547548
struct scx_cgroup_init_args *args);
548549

549550
/**
550-
* cgroup_exit - Exit a cgroup
551+
* @cgroup_exit: Exit a cgroup
551552
* @cgrp: cgroup being exited
552553
*
553554
* Either the BPF scheduler is being unloaded or @cgrp destroyed, exit
@@ -556,7 +557,7 @@ struct sched_ext_ops {
556557
void (*cgroup_exit)(struct cgroup *cgrp);
557558

558559
/**
559-
* cgroup_prep_move - Prepare a task to be moved to a different cgroup
560+
* @cgroup_prep_move: Prepare a task to be moved to a different cgroup
560561
* @p: task being moved
561562
* @from: cgroup @p is being moved from
562563
* @to: cgroup @p is being moved to
@@ -571,7 +572,7 @@ struct sched_ext_ops {
571572
struct cgroup *from, struct cgroup *to);
572573

573574
/**
574-
* cgroup_move - Commit cgroup move
575+
* @cgroup_move: Commit cgroup move
575576
* @p: task being moved
576577
* @from: cgroup @p is being moved from
577578
* @to: cgroup @p is being moved to
@@ -582,7 +583,7 @@ struct sched_ext_ops {
582583
struct cgroup *from, struct cgroup *to);
583584

584585
/**
585-
* cgroup_cancel_move - Cancel cgroup move
586+
* @cgroup_cancel_move: Cancel cgroup move
586587
* @p: task whose cgroup move is being canceled
587588
* @from: cgroup @p was being moved from
588589
* @to: cgroup @p was being moved to
@@ -594,7 +595,7 @@ struct sched_ext_ops {
594595
struct cgroup *from, struct cgroup *to);
595596

596597
/**
597-
* cgroup_set_weight - A cgroup's weight is being changed
598+
* @cgroup_set_weight: A cgroup's weight is being changed
598599
* @cgrp: cgroup whose weight is being updated
599600
* @weight: new weight [1..10000]
600601
*
@@ -608,7 +609,7 @@ struct sched_ext_ops {
608609
*/
609610

610611
/**
611-
* cpu_online - A CPU became online
612+
* @cpu_online: A CPU became online
612613
* @cpu: CPU which just came up
613614
*
614615
* @cpu just came online. @cpu will not call ops.enqueue() or
@@ -617,7 +618,7 @@ struct sched_ext_ops {
617618
void (*cpu_online)(s32 cpu);
618619

619620
/**
620-
* cpu_offline - A CPU is going offline
621+
* @cpu_offline: A CPU is going offline
621622
* @cpu: CPU which is going offline
622623
*
623624
* @cpu is going offline. @cpu will not call ops.enqueue() or
@@ -630,12 +631,12 @@ struct sched_ext_ops {
630631
*/
631632

632633
/**
633-
* init - Initialize the BPF scheduler
634+
* @init: Initialize the BPF scheduler
634635
*/
635636
s32 (*init)(void);
636637

637638
/**
638-
* exit - Clean up after the BPF scheduler
639+
* @exit: Clean up after the BPF scheduler
639640
* @info: Exit info
640641
*
641642
* ops.exit() is also called on ops.init() failure, which is a bit
@@ -645,17 +646,17 @@ struct sched_ext_ops {
645646
void (*exit)(struct scx_exit_info *info);
646647

647648
/**
648-
* dispatch_max_batch - Max nr of tasks that dispatch() can dispatch
649+
* @dispatch_max_batch: Max nr of tasks that dispatch() can dispatch
649650
*/
650651
u32 dispatch_max_batch;
651652

652653
/**
653-
* flags - %SCX_OPS_* flags
654+
* @flags: %SCX_OPS_* flags
654655
*/
655656
u64 flags;
656657

657658
/**
658-
* timeout_ms - The maximum amount of time, in milliseconds, that a
659+
* @timeout_ms: The maximum amount of time, in milliseconds, that a
659660
* runnable task should be able to wait before being scheduled. The
660661
* maximum timeout may not exceed the default timeout of 30 seconds.
661662
*
@@ -664,13 +665,13 @@ struct sched_ext_ops {
664665
u32 timeout_ms;
665666

666667
/**
667-
* exit_dump_len - scx_exit_info.dump buffer length. If 0, the default
668+
* @exit_dump_len: scx_exit_info.dump buffer length. If 0, the default
668669
* value of 32768 is used.
669670
*/
670671
u32 exit_dump_len;
671672

672673
/**
673-
* hotplug_seq - A sequence number that may be set by the scheduler to
674+
* @hotplug_seq: A sequence number that may be set by the scheduler to
674675
* detect when a hotplug event has occurred during the loading process.
675676
* If 0, no detection occurs. Otherwise, the scheduler will fail to
676677
* load if the sequence number does not match @scx_hotplug_seq on the
@@ -679,7 +680,7 @@ struct sched_ext_ops {
679680
u64 hotplug_seq;
680681

681682
/**
682-
* name - BPF scheduler's name
683+
* @name: BPF scheduler's name
683684
*
684685
* Must be a non-zero valid BPF object name including only isalnum(),
685686
* '_' and '.' chars. Shows up in kernel.sched_ext_ops sysctl while the
@@ -1408,7 +1409,6 @@ static struct task_struct *scx_task_iter_next(struct scx_task_iter *iter)
14081409
/**
14091410
* scx_task_iter_next_locked - Next non-idle task with its rq locked
14101411
* @iter: iterator to walk
1411-
* @include_dead: Whether we should include dead tasks in the iteration
14121412
*
14131413
* Visit the non-idle task with its rq lock held. Allows callers to specify
14141414
* whether they would like to filter out dead tasks. See scx_task_iter_start()
@@ -3132,6 +3132,7 @@ static struct task_struct *pick_task_scx(struct rq *rq)
31323132
* scx_prio_less - Task ordering for core-sched
31333133
* @a: task A
31343134
* @b: task B
3135+
* @in_fi: in forced idle state
31353136
*
31363137
* Core-sched is implemented as an additional scheduling layer on top of the
31373138
* usual sched_class'es and needs to find out the expected task ordering. For
@@ -4700,6 +4701,7 @@ bool task_should_scx(int policy)
47004701

47014702
/**
47024703
* scx_softlockup - sched_ext softlockup handler
4704+
* @dur_s: number of seconds of CPU stuck due to soft lockup
47034705
*
47044706
* On some multi-socket setups (e.g. 2x Intel 8480c), the BPF scheduler can
47054707
* live-lock the system by making many CPUs target the same DSQ to the point
@@ -4743,6 +4745,7 @@ static void scx_clear_softlockup(void)
47434745

47444746
/**
47454747
* scx_ops_bypass - [Un]bypass scx_ops and guarantee forward progress
4748+
* @bypass: true for bypass, false for unbypass
47464749
*
47474750
* Bypassing guarantees that all runnable tasks make forward progress without
47484751
* trusting the BPF scheduler. We can't grab any mutexes or rwsems as they might
@@ -7254,7 +7257,7 @@ __bpf_kfunc void scx_bpf_error_bstr(char *fmt, unsigned long long *data,
72547257
}
72557258

72567259
/**
7257-
* scx_bpf_dump - Generate extra debug dump specific to the BPF scheduler
7260+
* scx_bpf_dump_bstr - Generate extra debug dump specific to the BPF scheduler
72587261
* @fmt: format string
72597262
* @data: format string parameters packaged using ___bpf_fill() macro
72607263
* @data__sz: @data len, must end in '__sz' for the verifier
@@ -7346,7 +7349,6 @@ __bpf_kfunc u32 scx_bpf_cpuperf_cur(s32 cpu)
73467349
* scx_bpf_cpuperf_set - Set the relative performance target of a CPU
73477350
* @cpu: CPU of interest
73487351
* @perf: target performance level [0, %SCX_CPUPERF_ONE]
7349-
* @flags: %SCX_CPUPERF_* flags
73507352
*
73517353
* Set the target performance level of @cpu to @perf. @perf is in linear
73527354
* relative scale between 0 and %SCX_CPUPERF_ONE. This determines how the
@@ -7458,6 +7460,7 @@ __bpf_kfunc const struct cpumask *scx_bpf_get_idle_smtmask(void)
74587460
/**
74597461
* scx_bpf_put_idle_cpumask - Release a previously acquired referenced kptr to
74607462
* either the percpu, or SMT idle-tracking cpumask.
7463+
* @idle_mask: &cpumask to use
74617464
*/
74627465
__bpf_kfunc void scx_bpf_put_idle_cpumask(const struct cpumask *idle_mask)
74637466
{

0 commit comments

Comments
 (0)