usb: typec: fix unreleased fwnode_handle in typec_port_register_altmodes()

javiercarrascocruz · gregkh · commit 9581acb91eaf · 2024-10-29T04:28:51.000+01:00
The 'altmodes_node' fwnode_handle is never released after it is no longer required, which leaks the resource. Add the required call to fwnode_handle_put() when 'altmodes_node' is no longer required. Cc: stable@vger.kernel.org Fixes: 7b458a4 ("usb: typec: Add typec_port_register_altmodes()") Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> Link: https://lore.kernel.org/r/20241021-typec-class-fwnode_handle_put-v2-1-3281225d3d27@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
@@ -2341,6 +2341,7 @@ void typec_port_register_altmodes(struct typec_port *port,
 		altmodes[index] = alt;
 		index++;
 	}
+	fwnode_handle_put(altmodes_node);
 }
 EXPORT_SYMBOL_GPL(typec_port_register_altmodes);
 

Original file line number	Diff line number	Diff line change
`@@ -2341,6 +2341,7 @@ void typec_port_register_altmodes(struct typec_port *port,`
`2341`	`2341`	`altmodes[index] = alt;`
`2342`	`2342`	`index++;`
`2343`	`2343`	`}`
	`2344`	`+ fwnode_handle_put(altmodes_node);`
`2344`	`2345`	`}`
`2345`	`2346`	`EXPORT_SYMBOL_GPL(typec_port_register_altmodes);`
`2346`	`2347`