Skip to content

Commit 950a3c3

Browse files
tititiou36lag-linaro
authored andcommitted
mfd: 88pm886: Constify struct regmap_irq_chip and some other structures
'struct regmap_irq_chip' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increase overall security, especially when the structure holds some function pointers. While at it, also constify some other structures. On a x86_64, with allmodconfig, as an example: Before: ====== text data bss dec hex filename 5032 3304 64 8400 20d0 drivers/mfd/88pm886.o After: ===== text data bss dec hex filename 5800 2536 64 8400 20d0 drivers/mfd/88pm886.o Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/1681629840761e30494cb8920668710df60a81b8.1746996137.git.christophe.jaillet@wanadoo.fr Signed-off-by: Lee Jones <lee@kernel.org>
1 parent bdc76c1 commit 950a3c3

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/mfd/88pm886.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ static const struct regmap_config pm886_regmap_config = {
1616
.max_register = PM886_REG_RTC_SPARE6,
1717
};
1818

19-
static struct regmap_irq pm886_regmap_irqs[] = {
19+
static const struct regmap_irq pm886_regmap_irqs[] = {
2020
REGMAP_IRQ_REG(PM886_IRQ_ONKEY, 0, PM886_INT_ENA1_ONKEY),
2121
};
2222

23-
static struct regmap_irq_chip pm886_regmap_irq_chip = {
23+
static const struct regmap_irq_chip pm886_regmap_irq_chip = {
2424
.name = "88pm886",
2525
.irqs = pm886_regmap_irqs,
2626
.num_irqs = ARRAY_SIZE(pm886_regmap_irqs),
@@ -30,11 +30,11 @@ static struct regmap_irq_chip pm886_regmap_irq_chip = {
3030
.unmask_base = PM886_REG_INT_ENA_1,
3131
};
3232

33-
static struct resource pm886_onkey_resources[] = {
33+
static const struct resource pm886_onkey_resources[] = {
3434
DEFINE_RES_IRQ_NAMED(PM886_IRQ_ONKEY, "88pm886-onkey"),
3535
};
3636

37-
static struct mfd_cell pm886_devs[] = {
37+
static const struct mfd_cell pm886_devs[] = {
3838
MFD_CELL_RES("88pm886-onkey", pm886_onkey_resources),
3939
MFD_CELL_NAME("88pm886-regulator"),
4040
MFD_CELL_NAME("88pm886-rtc"),

0 commit comments

Comments
 (0)