Skip to content

Commit 9462e74

Browse files
spandruvadaij-intel
authored andcommitted
platform/x86: ISST: Correct command storage data length
After resume/online turbo limit ratio (TRL) is restored partially if the admin explicitly changed TRL from user space. A hash table is used to store SST mail box and MSR settings when modified to restore those settings after resume or online. This uses a struct isst_cmd field "data" to store these settings. This is a 64 bit field. But isst_store_new_cmd() is only assigning as u32. This results in truncation of 32 bits. Change the argument to u64 from u32. Fixes: f607874 ("platform/x86: ISST: Restore state on resume") Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20250328224749.2691272-1-srinivas.pandruvada@linux.intel.com Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
1 parent 2b9f84e commit 9462e74

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/platform/x86/intel/speed_select_if/isst_if_common.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ static DECLARE_HASHTABLE(isst_hash, 8);
8484
static DEFINE_MUTEX(isst_hash_lock);
8585

8686
static int isst_store_new_cmd(int cmd, u32 cpu, int mbox_cmd_type, u32 param,
87-
u32 data)
87+
u64 data)
8888
{
8989
struct isst_cmd *sst_cmd;
9090

0 commit comments

Comments
 (0)