Skip to content

Commit 8f21943

Browse files
committed
tracing: Fix output of set_event for some cached module events
The following works fine: ~# echo ':mod:trace_events_sample' > /sys/kernel/tracing/set_event ~# cat /sys/kernel/tracing/set_event *:*:mod:trace_events_sample ~# But if a name is given without a ':' where it can match an event name or system name, the output of the cached events does not include a new line: ~# echo 'foo_bar:mod:trace_events_sample' > /sys/kernel/tracing/set_event ~# cat /sys/kernel/tracing/set_event foo_bar:mod:trace_events_sample~# Add the '\n' to that as well. Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Link: https://lore.kernel.org/20250121151336.6c491844@gandalf.local.home Fixes: b355247 ("tracing: Cache ":mod:" events for modules not loaded yet") Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent f95ee54 commit 8f21943

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/trace/trace_events.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1634,7 +1634,7 @@ static int s_show(struct seq_file *m, void *v)
16341634

16351635
/* When match is set, system and event are not */
16361636
if (iter->event_mod->match) {
1637-
seq_printf(m, "%s:mod:%s", iter->event_mod->match,
1637+
seq_printf(m, "%s:mod:%s\n", iter->event_mod->match,
16381638
iter->event_mod->module);
16391639
return 0;
16401640
}

0 commit comments

Comments
 (0)