Skip to content

Commit 8ece9d2

Browse files
akemnadelag-linaro
authored andcommitted
dt-bindings: mfd: bd71828: Use charger resistor in mOhm instead of MOhm
Apparently there was some confusion regarding milliohm vs. megaohm. (m/M). Use microohms to be able to properly specify the charger resistor like other drivers do. This is not used yet by mainline code yet. Specify a current sense resistor in milliohms range rather then megaohms range in the examples. CC: sre@kernel.org Reported-by: Matti Vaittinen <mazziesaccount@gmail.com> Closes: https://lore.kernel.org/imx/6dcd724a-a55c-4cba-a45b-21e76b1973b0@gmail.com/T/#mf590875a9f4d3955cd1041d7196ff0c65c0a7e9d Signed-off-by: Andreas Kemnade <andreas@kemnade.info> Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> Fixes: 1af5332 ("dt-bindings: mfd: Document ROHM BD71828 bindings") Link: https://lore.kernel.org/r/20241111102701.358133-1-andreas@kemnade.info Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 131a975 commit 8ece9d2

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,15 @@ properties:
5555
minimum: 0
5656
maximum: 1
5757

58-
rohm,charger-sense-resistor-ohms:
59-
minimum: 10000000
60-
maximum: 50000000
58+
rohm,charger-sense-resistor-micro-ohms:
59+
minimum: 10000
60+
maximum: 50000
61+
default: 30000
6162
description: |
6263
BD71827 and BD71828 have SAR ADC for measuring charging currents.
6364
External sense resistor (RSENSE in data sheet) should be used. If some
64-
other but 30MOhm resistor is used the resistance value should be given
65-
here in Ohms.
65+
other but 30mOhm resistor is used the resistance value should be given
66+
here in microohms.
6667
6768
regulators:
6869
$ref: /schemas/regulator/rohm,bd71828-regulator.yaml
@@ -114,7 +115,7 @@ examples:
114115
#gpio-cells = <2>;
115116
gpio-reserved-ranges = <0 1>, <2 1>;
116117
117-
rohm,charger-sense-resistor-ohms = <10000000>;
118+
rohm,charger-sense-resistor-micro-ohms = <10000>;
118119
119120
regulators {
120121
buck1: BUCK1 {

0 commit comments

Comments
 (0)