Skip to content

Commit 89434b0

Browse files
RD Babieragregkh
authored andcommitted
usb: typec: altmodes/displayport: Signal hpd low when exiting mode
Upon receiving an ACK for a sent EXIT_MODE message, the DisplayPort driver currently resets the status and configuration of the port partner. The hpd signal is not updated despite being part of the status, so the Display stack can still transmit video despite typec_altmode_exit placing the lanes in a Safe State. Set hpd to low when a sent EXIT_MODE message is ACK'ed. Fixes: 0e3bb7d ("usb: typec: Add driver for DisplayPort alternate mode") Cc: stable@vger.kernel.org Signed-off-by: RD Babiera <rdbabiera@google.com> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Link: https://lore.kernel.org/r/20231009210057.3773877-2-rdbabiera@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent cf97c5e commit 89434b0

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

drivers/usb/typec/altmodes/displayport.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,11 @@ static int dp_altmode_vdm(struct typec_altmode *alt,
304304
typec_altmode_update_active(alt, false);
305305
dp->data.status = 0;
306306
dp->data.conf = 0;
307+
if (dp->hpd) {
308+
drm_connector_oob_hotplug_event(dp->connector_fwnode);
309+
dp->hpd = false;
310+
sysfs_notify(&dp->alt->dev.kobj, "displayport", "hpd");
311+
}
307312
break;
308313
case DP_CMD_STATUS_UPDATE:
309314
dp->data.status = *vdo;

0 commit comments

Comments
 (0)