Skip to content

Commit 8789b42

Browse files
andredvinodkoul
authored andcommitted
phy: exynos5-usbdrd: gs101: ensure power is gated to SS phy in phy_exit()
We currently don't gate the power to the SS phy in phy_exit(). Shuffle the code slightly to ensure the power is gated to the SS phy as well. Fixes: 32267c2 ("phy: exynos5-usbdrd: support Exynos USBDRD 3.1 combo phy (HS & SS)") CC: stable@vger.kernel.org # 6.11+ Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Peter Griffin <peter.griffin@linaro.org> Signed-off-by: André Draszik <andre.draszik@linaro.org> Link: https://lore.kernel.org/r/20241205-gs101-usb-phy-fix-v4-1-0278809fb810@linaro.org Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent cd57e43 commit 8789b42

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

drivers/phy/samsung/phy-exynos5-usbdrd.c

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1296,14 +1296,17 @@ static int exynos5_usbdrd_gs101_phy_exit(struct phy *phy)
12961296
struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst);
12971297
int ret;
12981298

1299+
if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI) {
1300+
ret = exynos850_usbdrd_phy_exit(phy);
1301+
if (ret)
1302+
return ret;
1303+
}
1304+
1305+
exynos5_usbdrd_phy_isol(inst, true);
1306+
12991307
if (inst->phy_cfg->id != EXYNOS5_DRDPHY_UTMI)
13001308
return 0;
13011309

1302-
ret = exynos850_usbdrd_phy_exit(phy);
1303-
if (ret)
1304-
return ret;
1305-
1306-
exynos5_usbdrd_phy_isol(inst, true);
13071310
return regulator_bulk_disable(phy_drd->drv_data->n_regulators,
13081311
phy_drd->regulators);
13091312
}

0 commit comments

Comments
 (0)