Skip to content

Commit 861ab81

Browse files
author
Hans Verkuil
committed
media: bt8xx: bttv_risc_packed(): remove field checks
Do not turn on the vcr_hack based on the btv->field value. This was a change in the bttv vb2 conversion that caused green lines at the bottom of the picture in tvtime. It was originally added to the vb2 conversion based on faulty information that without this there would be glitches in the video. However, later tests suggest that this is a problem in the utilities used to test this since tvtime behaves fine. This patch reverts the bttv driver to the original pre-vb2 behavior w.r.t. vcr_hack. Fixes: b7ec321 ("media: bttv: convert to vb2") Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
1 parent 12d21fc commit 861ab81

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/media/pci/bt8xx/bttv-risc.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,7 @@ bttv_risc_packed(struct bttv *btv, struct btcx_riscmem *risc,
6868
sg = sglist;
6969
for (line = 0; line < store_lines; line++) {
7070
if ((line >= (store_lines - VCR_HACK_LINES)) &&
71-
(btv->opt_vcr_hack ||
72-
(V4L2_FIELD_HAS_BOTH(btv->field) ||
73-
btv->field == V4L2_FIELD_ALTERNATE)))
71+
btv->opt_vcr_hack)
7472
continue;
7573
while (offset && offset >= sg_dma_len(sg)) {
7674
offset -= sg_dma_len(sg);

0 commit comments

Comments
 (0)