Skip to content

Commit 84294c8

Browse files
krzkWolfram Sang
authored andcommitted
i2c: simplify with scoped for each OF child loop
Use scoped for_each_child_of_node_scoped() when iterating over device nodes to make code a bit simpler. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
1 parent 6c909b6 commit 84294c8

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

drivers/i2c/i2c-core-slave.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -109,15 +109,12 @@ EXPORT_SYMBOL_GPL(i2c_slave_event);
109109
bool i2c_detect_slave_mode(struct device *dev)
110110
{
111111
if (IS_BUILTIN(CONFIG_OF) && dev->of_node) {
112-
struct device_node *child;
113112
u32 reg;
114113

115-
for_each_child_of_node(dev->of_node, child) {
114+
for_each_child_of_node_scoped(dev->of_node, child) {
116115
of_property_read_u32(child, "reg", &reg);
117-
if (reg & I2C_OWN_SLAVE_ADDRESS) {
118-
of_node_put(child);
116+
if (reg & I2C_OWN_SLAVE_ADDRESS)
119117
return true;
120-
}
121118
}
122119
} else if (IS_BUILTIN(CONFIG_ACPI) && ACPI_HANDLE(dev)) {
123120
dev_dbg(dev, "ACPI slave is not supported yet\n");

0 commit comments

Comments
 (0)