Skip to content

Commit 8239b77

Browse files
tatyana-enanguy11
authored andcommitted
ice: Replace ice specific DSCP mapping num with a kernel define
Replace ice driver specific DSCP mapping number defines ICE_DSCP_NUM_VAL and IIDC_MAX_DSCP_MAPPING with an equivalent kernel define DSCP_MAX. Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova@intel.com> Signed-off-by: Dave Ertman <david.m.ertman@intel.com> Reviewed-by: Simon Horman <horms@kernel.org> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
1 parent d9251a5 commit 8239b77

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

drivers/net/ethernet/intel/ice/ice_dcb.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1288,7 +1288,7 @@ ice_add_dscp_up_tlv(struct ice_lldp_org_tlv *tlv, struct ice_dcbx_cfg *dcbcfg)
12881288
tlv->ouisubtype = htonl(ouisubtype);
12891289

12901290
/* bytes 0 - 63 - IPv4 DSCP2UP LUT */
1291-
for (i = 0; i < ICE_DSCP_NUM_VAL; i++) {
1291+
for (i = 0; i < DSCP_MAX; i++) {
12921292
/* IPv4 mapping */
12931293
buf[i] = dcbcfg->dscp_map[i];
12941294
/* IPv6 mapping */

drivers/net/ethernet/intel/ice/ice_dcb_nl.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -754,7 +754,7 @@ static int ice_dcbnl_setapp(struct net_device *netdev, struct dcb_app *app)
754754
if (!ice_is_feature_supported(pf, ICE_F_DSCP))
755755
return -EOPNOTSUPP;
756756

757-
if (app->protocol >= ICE_DSCP_NUM_VAL) {
757+
if (app->protocol >= DSCP_MAX) {
758758
netdev_err(netdev, "DSCP value 0x%04X out of range\n",
759759
app->protocol);
760760
return -EINVAL;
@@ -931,7 +931,7 @@ static int ice_dcbnl_delapp(struct net_device *netdev, struct dcb_app *app)
931931
/* if the last DSCP mapping just got deleted, need to switch
932932
* to L2 VLAN QoS mode
933933
*/
934-
if (bitmap_empty(new_cfg->dscp_mapped, ICE_DSCP_NUM_VAL) &&
934+
if (bitmap_empty(new_cfg->dscp_mapped, DSCP_MAX) &&
935935
new_cfg->pfc_mode == ICE_QOS_MODE_DSCP) {
936936
ret = ice_aq_set_pfc_mode(&pf->hw,
937937
ICE_AQC_PFC_VLAN_BASED_PFC,

drivers/net/ethernet/intel/ice/ice_idc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ void ice_get_qos_params(struct ice_pf *pf, struct iidc_rdma_qos_params *qos)
225225

226226
qos->pfc_mode = dcbx_cfg->pfc_mode;
227227
if (qos->pfc_mode == IIDC_DSCP_PFC_MODE)
228-
for (i = 0; i < IIDC_MAX_DSCP_MAPPING; i++)
228+
for (i = 0; i < DSCP_MAX; i++)
229229
qos->dscp_map[i] = dcbx_cfg->dscp_map[i];
230230
}
231231
EXPORT_SYMBOL_GPL(ice_get_qos_params);

drivers/net/ethernet/intel/ice/ice_type.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
#include "ice_vlan_mode.h"
2020
#include "ice_fwlog.h"
2121
#include <linux/wait.h>
22+
#include <net/dscp.h>
2223

2324
static inline bool ice_is_tc_ena(unsigned long bitmap, u8 tc)
2425
{
@@ -695,7 +696,6 @@ struct ice_dcb_app_priority_table {
695696

696697
#define ICE_MAX_USER_PRIORITY 8
697698
#define ICE_DCBX_MAX_APPS 64
698-
#define ICE_DSCP_NUM_VAL 64
699699
#define ICE_LLDPDU_SIZE 1500
700700
#define ICE_TLV_STATUS_OPER 0x1
701701
#define ICE_TLV_STATUS_SYNC 0x2
@@ -718,9 +718,9 @@ struct ice_dcbx_cfg {
718718
u8 pfc_mode;
719719
struct ice_dcb_app_priority_table app[ICE_DCBX_MAX_APPS];
720720
/* when DSCP mapping defined by user set its bit to 1 */
721-
DECLARE_BITMAP(dscp_mapped, ICE_DSCP_NUM_VAL);
721+
DECLARE_BITMAP(dscp_mapped, DSCP_MAX);
722722
/* array holding DSCP -> UP/TC values for DSCP L3 QoS mode */
723-
u8 dscp_map[ICE_DSCP_NUM_VAL];
723+
u8 dscp_map[DSCP_MAX];
724724
u8 dcbx_mode;
725725
#define ICE_DCBX_MODE_CEE 0x1
726726
#define ICE_DCBX_MODE_IEEE 0x2

include/linux/net/intel/iidc_rdma.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#include <linux/if_ether.h>
1111
#include <linux/kernel.h>
1212
#include <linux/netdevice.h>
13+
#include <net/dscp.h>
1314

1415
enum iidc_rdma_event_type {
1516
IIDC_RDMA_EVENT_BEFORE_MTU_CHANGE,
@@ -32,7 +33,6 @@ enum iidc_rdma_protocol {
3233
};
3334

3435
#define IIDC_MAX_USER_PRIORITY 8
35-
#define IIDC_MAX_DSCP_MAPPING 64
3636
#define IIDC_DSCP_PFC_MODE 0x1
3737

3838
/* Struct to hold per RDMA Qset info */
@@ -63,7 +63,7 @@ struct iidc_rdma_qos_params {
6363
u8 vport_priority_type;
6464
u8 num_tc;
6565
u8 pfc_mode;
66-
u8 dscp_map[IIDC_MAX_DSCP_MAPPING];
66+
u8 dscp_map[DSCP_MAX];
6767
};
6868

6969
struct iidc_rdma_event {

0 commit comments

Comments
 (0)