Skip to content

Commit 7dfc9bd

Browse files
Dan Carpenterbroonie
authored andcommitted
spi: stm32-ospi: Fix an IS_ERR() vs NULL bug in stm32_ospi_get_resources()
The devm_ioremap() function returns NULL on error, it doesn't return error pointers. Fix the check to match. Fixes: 79b8a70 ("spi: stm32: Add OSPI driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> Link: https://patch.msgid.link/bc4c9123-df43-4616-962f-765801d30b4c@stanley.mountain Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 5fac6c2 commit 7dfc9bd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/spi/spi-stm32-ospi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -835,10 +835,10 @@ static int stm32_ospi_get_resources(struct platform_device *pdev)
835835
if (rmem) {
836836
ospi->mm_size = rmem->size;
837837
ospi->mm_base = devm_ioremap(dev, rmem->base, rmem->size);
838-
if (IS_ERR(ospi->mm_base)) {
838+
if (!ospi->mm_base) {
839839
dev_err(dev, "unable to map memory region: %pa+%pa\n",
840840
&rmem->base, &rmem->size);
841-
ret = PTR_ERR(ospi->mm_base);
841+
ret = -ENOMEM;
842842
goto err_dma;
843843
}
844844

0 commit comments

Comments
 (0)