PCI: rockchip-ep: Fix error code in rockchip_pcie_ep_init_ob_mem()

Dan Carpenter · kwilczynski · commit 7ca288760007 · 2025-01-15T18:24:12.000Z
Return -ENOMEM if pci_epc_mem_alloc_addr() fails. Don't return success. Link: https://lore.kernel.org/r/Z014ylYz_xrrgI4W@stanley.mountain Fixes: 9456480 ("PCI: rockchip-ep: Refactor rockchip_pcie_ep_probe() memory allocations") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Reviewed-by: Niklas Cassel <cassel@kernel.org>
diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c
@@ -788,6 +788,7 @@ static int rockchip_pcie_ep_init_ob_mem(struct rockchip_pcie_ep *ep)
 						  SZ_1M);
 	if (!ep->irq_cpu_addr) {
 		dev_err(dev, "failed to reserve memory space for MSI\n");
+		err = -ENOMEM;
 		goto err_epc_mem_exit;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -788,6 +788,7 @@ static int rockchip_pcie_ep_init_ob_mem(struct rockchip_pcie_ep *ep)`
`788`	`788`	`SZ_1M);`
`789`	`789`	`if (!ep->irq_cpu_addr) {`
`790`	`790`	`dev_err(dev, "failed to reserve memory space for MSI\n");`
	`791`	`+ err = -ENOMEM;`
`791`	`792`	`goto err_epc_mem_exit;`
`792`	`793`	`}`
`793`	`794`