Skip to content

Commit 75da043

Browse files
committed
cpufreq/sched: Set need_freq_update in ignore_dl_rate_limit()
Notice that ignore_dl_rate_limit() need not piggy back on the limits_changed handling to achieve its goal (which is to enforce a frequency update before its due time). Namely, if sugov_should_update_freq() is updated to check sg_policy->need_freq_update and return 'true' if it is set when sg_policy->limits_changed is not set, ignore_dl_rate_limit() may set the former directly instead of setting the latter, so it can avoid hitting the memory barrier in sugov_should_update_freq(). Update the code accordingly. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Reviewed-by: Christian Loehle <christian.loehle@arm.com> Link: https://patch.msgid.link/10666429.nUPlyArG6x@rjwysocki.net
1 parent 79443a7 commit 75da043

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

kernel/sched/cpufreq_schedutil.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,9 @@ static bool sugov_should_update_freq(struct sugov_policy *sg_policy, u64 time)
9595
*/
9696
smp_mb();
9797

98+
return true;
99+
} else if (sg_policy->need_freq_update) {
100+
/* ignore_dl_rate_limit() wants a new frequency to be found. */
98101
return true;
99102
}
100103

@@ -388,7 +391,7 @@ static inline bool sugov_hold_freq(struct sugov_cpu *sg_cpu) { return false; }
388391
static inline void ignore_dl_rate_limit(struct sugov_cpu *sg_cpu)
389392
{
390393
if (cpu_bw_dl(cpu_rq(sg_cpu->cpu)) > sg_cpu->bw_min)
391-
WRITE_ONCE(sg_cpu->sg_policy->limits_changed, true);
394+
sg_cpu->sg_policy->need_freq_update = true;
392395
}
393396

394397
static inline bool sugov_update_single_common(struct sugov_cpu *sg_cpu,

0 commit comments

Comments
 (0)