Skip to content

Commit 72e1c44

Browse files
committed
auxdisplay: panel: Fix an API misuse in panel.c
Variable allocated by charlcd_alloc() should be released by charlcd_free(). The following patch changed kfree() to charlcd_free() to fix an API misuse. Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Fixes: 718e05e ("auxdisplay: Introduce hd44780_common.[ch]") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
1 parent 9b98a7d commit 72e1c44

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/auxdisplay/panel.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1664,7 +1664,7 @@ static void panel_attach(struct parport *port)
16641664
if (lcd.enabled)
16651665
charlcd_unregister(lcd.charlcd);
16661666
err_unreg_device:
1667-
kfree(lcd.charlcd);
1667+
charlcd_free(lcd.charlcd);
16681668
lcd.charlcd = NULL;
16691669
parport_unregister_device(pprt);
16701670
pprt = NULL;
@@ -1692,7 +1692,7 @@ static void panel_detach(struct parport *port)
16921692
charlcd_unregister(lcd.charlcd);
16931693
lcd.initialized = false;
16941694
kfree(lcd.charlcd->drvdata);
1695-
kfree(lcd.charlcd);
1695+
charlcd_free(lcd.charlcd);
16961696
lcd.charlcd = NULL;
16971697
}
16981698

0 commit comments

Comments
 (0)