Skip to content

Commit 7225216

Browse files
prabhakarladWolfram Sang
authored andcommitted
i2c: riic: Use GENMASK() macro for bitmask definitions
Replace raw bitmask values with the `GENMASK()` macro in the `i2c-riic` driver to improve readability and maintain consistency. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Tested-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> Reviewed-by: Andy Shevchenko <andy@kernel.org> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
1 parent 0094d6b commit 7225216

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/i2c/busses/i2c-riic.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
#define ICCR2_RS BIT(2)
5757
#define ICCR2_ST BIT(1)
5858

59-
#define ICMR1_CKS_MASK 0x70
59+
#define ICMR1_CKS_MASK GENMASK(6, 4)
6060
#define ICMR1_BCWP BIT(3)
6161
#define ICMR1_CKS(_x) ((((_x) << 4) & ICMR1_CKS_MASK) | ICMR1_BCWP)
6262

@@ -74,7 +74,7 @@
7474

7575
#define ICSR2_NACKF BIT(4)
7676

77-
#define ICBR_RESERVED 0xe0 /* Should be 1 on writes */
77+
#define ICBR_RESERVED GENMASK(7, 5) /* Should be 1 on writes */
7878

7979
#define RIIC_INIT_MSG -1
8080

0 commit comments

Comments
 (0)