Skip to content

Commit 6b6e2e8

Browse files
Rwantaregroeck
authored andcommitted
hwmon: (pmbus) Initialise page count in pmbus_identify()
The `pmbus_identify()` function fails to correctly determine the number of supported pages on PMBus devices. This occurs because `info->pages` is implicitly zero-initialised, and `pmbus_set_page()` does not perform writes to the page register if `info->pages` is not yet initialised. Without this patch, `info->pages` is always set to the maximum after scanning. This patch initialises `info->pages` to `PMBUS_PAGES` before the probing loop, enabling `pmbus_set_page()` writes to make it out onto the bus correctly identifying the number of pages. `PMBUS_PAGES` seemed like a reasonable non-zero number because that's the current result of the identification process. Testing was done with a PMBus device in QEMU. Signed-off-by: Titus Rwantare <titusr@google.com> Fixes: 442aba7 ("hwmon: PMBus device driver") Link: https://lore.kernel.org/r/20250227222455.2583468-1-titusr@google.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent 5797c04 commit 6b6e2e8

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/hwmon/pmbus/pmbus.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,8 @@ static int pmbus_identify(struct i2c_client *client,
103103
if (pmbus_check_byte_register(client, 0, PMBUS_PAGE)) {
104104
int page;
105105

106+
info->pages = PMBUS_PAGES;
107+
106108
for (page = 1; page < PMBUS_PAGES; page++) {
107109
if (pmbus_set_page(client, page, 0xff) < 0)
108110
break;

0 commit comments

Comments
 (0)