Skip to content

Commit 6afdc60

Browse files
committed
udf: Fix inode_getblk() return value
Smatch noticed that inode_getblk() can return 1 on successful mapping of a block instead of expected 0 after commit b405c1e ("udf: refactor udf_next_aext() to handle error"). This could confuse some of the callers and lead to strange failures (although the one reported by Smatch in udf_mkdir() is impossible to trigger in practice). Fix the return value of inode_getblk(). Link: https://lore.kernel.org/all/cb514af7-bbe0-435b-934f-dd1d7a16d2cd@stanley.mountain Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com> Fixes: b405c1e ("udf: refactor udf_next_aext() to handle error") CC: stable@vger.kernel.org Signed-off-by: Jan Kara <jack@suse.cz>
1 parent a7624cc commit 6afdc60

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

fs/udf/inode.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -810,6 +810,7 @@ static int inode_getblk(struct inode *inode, struct udf_map_rq *map)
810810
}
811811
map->oflags = UDF_BLK_MAPPED;
812812
map->pblk = udf_get_lb_pblock(inode->i_sb, &eloc, offset);
813+
ret = 0;
813814
goto out_free;
814815
}
815816

0 commit comments

Comments
 (0)