zram: free secondary algorithms names

sergey-senozhatsky · akpm00 · commit 684826f8271a · 2024-09-17T01:07:01.000-07:00
We need to kfree() secondary algorithms names when reset zram device that had multi-streams, otherwise we leak memory. [senozhatsky@chromium.org: kfree(NULL) is legal] Link: https://lkml.kernel.org/r/20240917013021.868769-1-senozhatsky@chromium.org Link: https://lkml.kernel.org/r/20240911025600.3681789-1-senozhatsky@chromium.org Fixes: 001d927 ("zram: add recompression algorithm sysfs knob") Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org> Cc: Minchan Kim <minchan@kernel.org> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
@@ -2112,6 +2112,11 @@ static void zram_destroy_comps(struct zram *zram)
 		zram->num_active_comps--;
 	}
 
+	for (prio = ZRAM_SECONDARY_COMP; prio < ZRAM_MAX_COMPS; prio++) {
+		kfree(zram->comp_algs[prio]);
+		zram->comp_algs[prio] = NULL;
+	}
+
 	zram_comp_params_reset(zram);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2112,6 +2112,11 @@ static void zram_destroy_comps(struct zram *zram)`
`2112`	`2112`	`zram->num_active_comps--;`
`2113`	`2113`	`}`
`2114`	`2114`
	`2115`	`+ for (prio = ZRAM_SECONDARY_COMP; prio < ZRAM_MAX_COMPS; prio++) {`
	`2116`	`+ kfree(zram->comp_algs[prio]);`
	`2117`	`+ zram->comp_algs[prio] = NULL;`
	`2118`	`+ }`
	`2119`	`+`
`2115`	`2120`	`zram_comp_params_reset(zram);`
`2116`	`2121`	`}`
`2117`	`2122`