Skip to content

Commit 66a0a2b

Browse files
committed
ALSA: sh: Fix wrong argument order for copy_from_iter()
Fix a brown paper bag bug I introduced at converting to the standard iter helper; the arguments were wrongly passed and have to be swapped. Fixes: 9b5f8ee ("ALSA: sh: Use standard helper for buffer accesses") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202412140019.jat5Dofr-lkp@intel.com/ Link: https://patch.msgid.link/20241220114417.5898-1-tiwai@suse.de Signed-off-by: Takashi Iwai <tiwai@suse.de>
1 parent 55853cb commit 66a0a2b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/sh/sh_dac_audio.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ static int snd_sh_dac_pcm_copy(struct snd_pcm_substream *substream,
163163
/* channel is not used (interleaved data) */
164164
struct snd_sh_dac *chip = snd_pcm_substream_chip(substream);
165165

166-
if (copy_from_iter(chip->data_buffer + pos, src, count) != count)
166+
if (copy_from_iter(chip->data_buffer + pos, count, src) != count)
167167
return -EFAULT;
168168
chip->buffer_end = chip->data_buffer + pos + count;
169169

0 commit comments

Comments
 (0)