Skip to content

Commit 6657d89

Browse files
Dr. David Alan GilbertJiri Kosina
authored andcommitted
HID: intel-ish-hid: Remove unused ishtp_cl_tx_empty
ishtp_cl_tx_empty() was added in 2018 by commit a1c40ce ("HID: intel-ish-hid: ishtp: add helper functions for client buffer operation") but has remained unused. Remove it. Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Signed-off-by: Jiri Kosina <jkosina@suse.com>
1 parent c59c46c commit 6657d89

File tree

2 files changed

+0
-22
lines changed

2 files changed

+0
-22
lines changed

drivers/hid/intel-ish-hid/ishtp/client-buffers.c

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -251,27 +251,6 @@ int ishtp_cl_io_rb_recycle(struct ishtp_cl_rb *rb)
251251
}
252252
EXPORT_SYMBOL(ishtp_cl_io_rb_recycle);
253253

254-
/**
255-
* ishtp_cl_tx_empty() -test whether client device tx buffer is empty
256-
* @cl: Pointer to client device instance
257-
*
258-
* Look client device tx buffer list, and check whether this list is empty
259-
*
260-
* Return: true if client tx buffer list is empty else false
261-
*/
262-
bool ishtp_cl_tx_empty(struct ishtp_cl *cl)
263-
{
264-
int tx_list_empty;
265-
unsigned long tx_flags;
266-
267-
spin_lock_irqsave(&cl->tx_list_spinlock, tx_flags);
268-
tx_list_empty = list_empty(&cl->tx_list.list);
269-
spin_unlock_irqrestore(&cl->tx_list_spinlock, tx_flags);
270-
271-
return !!tx_list_empty;
272-
}
273-
EXPORT_SYMBOL(ishtp_cl_tx_empty);
274-
275254
/**
276255
* ishtp_cl_rx_get_rb() -Get a rb from client device rx buffer list
277256
* @cl: Pointer to client device instance

include/linux/intel-ish-client-if.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ void ishtp_cl_destroy_connection(struct ishtp_cl *cl, bool reset);
100100
int ishtp_cl_send(struct ishtp_cl *cl, uint8_t *buf, size_t length);
101101
int ishtp_cl_flush_queues(struct ishtp_cl *cl);
102102
int ishtp_cl_io_rb_recycle(struct ishtp_cl_rb *rb);
103-
bool ishtp_cl_tx_empty(struct ishtp_cl *cl);
104103
struct ishtp_cl_rb *ishtp_cl_rx_get_rb(struct ishtp_cl *cl);
105104
void *ishtp_get_client_data(struct ishtp_cl *cl);
106105
void ishtp_set_client_data(struct ishtp_cl *cl, void *data);

0 commit comments

Comments
 (0)