Skip to content

Commit 64e02b6

Browse files
committed
firewire: core: record card index in tracepoinrts events derived from async_outbound_initiate_template
The asynchronous transaction is initiated on one of 1394 OHCI controller, however the existing tracepoints events has the lack of data about it. This commit adds card_index member into event structure to store the index of host controller in use, and prints it. Link: https://lore.kernel.org/r/20240613131440.431766-3-o-takashi@sakamocchi.jp Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
1 parent e7da16a commit 64e02b6

File tree

2 files changed

+18
-12
lines changed

2 files changed

+18
-12
lines changed

drivers/firewire/core-transaction.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,8 @@ void __fw_send_request(struct fw_card *card, struct fw_transaction *t, int tcode
398398

399399
spin_unlock_irqrestore(&card->lock, flags);
400400

401-
trace_async_request_outbound_initiate((uintptr_t)t, generation, speed, t->packet.header, payload,
401+
trace_async_request_outbound_initiate((uintptr_t)t, card->index, generation, speed,
402+
t->packet.header, payload,
402403
tcode_is_read_request(tcode) ? 0 : length / 4);
403404

404405
card->driver->send_request(card, &t->packet);
@@ -879,9 +880,10 @@ void fw_send_response(struct fw_card *card,
879880
// Increase the reference count so that the object is kept during in-flight.
880881
fw_request_get(request);
881882

882-
trace_async_response_outbound_initiate((uintptr_t)request, request->response.generation,
883-
request->response.speed, request->response.header,
884-
data, data ? data_length / 4 : 0);
883+
trace_async_response_outbound_initiate((uintptr_t)request, card->index,
884+
request->response.generation, request->response.speed,
885+
request->response.header, data,
886+
data ? data_length / 4 : 0);
885887

886888
card->driver->send_response(card, &request->response);
887889
}

include/trace/events/firewire.h

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,26 +36,29 @@
3636
#define QUADLET_SIZE 4
3737

3838
DECLARE_EVENT_CLASS(async_outbound_initiate_template,
39-
TP_PROTO(u64 transaction, unsigned int generation, unsigned int scode, const u32 *header, const u32 *data, unsigned int data_count),
40-
TP_ARGS(transaction, generation, scode, header, data, data_count),
39+
TP_PROTO(u64 transaction, unsigned int card_index, unsigned int generation, unsigned int scode, const u32 *header, const u32 *data, unsigned int data_count),
40+
TP_ARGS(transaction, card_index, generation, scode, header, data, data_count),
4141
TP_STRUCT__entry(
4242
__field(u64, transaction)
43+
__field(u8, card_index)
4344
__field(u8, generation)
4445
__field(u8, scode)
4546
__array(u32, header, ASYNC_HEADER_QUADLET_COUNT)
4647
__dynamic_array(u32, data, data_count)
4748
),
4849
TP_fast_assign(
4950
__entry->transaction = transaction;
51+
__entry->card_index = card_index;
5052
__entry->generation = generation;
5153
__entry->scode = scode;
5254
memcpy(__entry->header, header, QUADLET_SIZE * ASYNC_HEADER_QUADLET_COUNT);
5355
memcpy(__get_dynamic_array(data), data, __get_dynamic_array_len(data));
5456
),
5557
// This format is for the request subaction.
5658
TP_printk(
57-
"transaction=0x%llx generation=%u scode=%u dst_id=0x%04x tlabel=%u tcode=%u src_id=0x%04x offset=0x%012llx header=%s data=%s",
59+
"transaction=0x%llx card_index=%u generation=%u scode=%u dst_id=0x%04x tlabel=%u tcode=%u src_id=0x%04x offset=0x%012llx header=%s data=%s",
5860
__entry->transaction,
61+
__entry->card_index,
5962
__entry->generation,
6063
__entry->scode,
6164
ASYNC_HEADER_GET_DESTINATION(__entry->header),
@@ -142,8 +145,8 @@ DECLARE_EVENT_CLASS(async_inbound_template,
142145
);
143146

144147
DEFINE_EVENT(async_outbound_initiate_template, async_request_outbound_initiate,
145-
TP_PROTO(u64 transaction, unsigned int generation, unsigned int scode, const u32 *header, const u32 *data, unsigned int data_count),
146-
TP_ARGS(transaction, generation, scode, header, data, data_count)
148+
TP_PROTO(u64 transaction, unsigned int card_index, unsigned int generation, unsigned int scode, const u32 *header, const u32 *data, unsigned int data_count),
149+
TP_ARGS(transaction, card_index, generation, scode, header, data, data_count)
147150
);
148151

149152
DEFINE_EVENT(async_outbound_complete_template, async_request_outbound_complete,
@@ -178,11 +181,12 @@ DEFINE_EVENT_PRINT(async_inbound_template, async_request_inbound,
178181
);
179182

180183
DEFINE_EVENT_PRINT(async_outbound_initiate_template, async_response_outbound_initiate,
181-
TP_PROTO(u64 transaction, unsigned int generation, unsigned int scode, const u32 *header, const u32 *data, unsigned int data_count),
182-
TP_ARGS(transaction, generation, scode, header, data, data_count),
184+
TP_PROTO(u64 transaction, unsigned int card_index, unsigned int generation, unsigned int scode, const u32 *header, const u32 *data, unsigned int data_count),
185+
TP_ARGS(transaction, card_index, generation, scode, header, data, data_count),
183186
TP_printk(
184-
"transaction=0x%llx generation=%u scode=%u dst_id=0x%04x tlabel=%u tcode=%u src_id=0x%04x rcode=%u header=%s data=%s",
187+
"transaction=0x%llx card_index=%u generation=%u scode=%u dst_id=0x%04x tlabel=%u tcode=%u src_id=0x%04x rcode=%u header=%s data=%s",
185188
__entry->transaction,
189+
__entry->card_index,
186190
__entry->generation,
187191
__entry->scode,
188192
ASYNC_HEADER_GET_DESTINATION(__entry->header),

0 commit comments

Comments
 (0)