Skip to content

Commit 643f209

Browse files
zehortigozarodrigovivi
authored andcommitted
drm/xe: Make GUC binaries dump consistent with other binaries in devcoredump
All other(hwsp, hwctx and vmas) binaries follow this format: [name].length: 0x1000 [name].data: xxxxxxx [name].error: errno The error one is just in case by some reason it was not able to capture the binary. So this GuC binaries should follow the same patern. v2: - renamed GUC binary to LOG Cc: John Harrison <John.C.Harrison@Intel.com> Cc: Lucas De Marchi <lucas.demarchi@intel.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: José Roberto de Souza <jose.souza@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250123202307.95103-3-jose.souza@intel.com Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> (cherry picked from commit cb1f868) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent 0c455f3 commit 643f209

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

drivers/gpu/drm/xe/xe_guc_ct.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1723,9 +1723,11 @@ void xe_guc_ct_snapshot_print(struct xe_guc_ct_snapshot *snapshot,
17231723
drm_printf(p, "\tg2h outstanding: %d\n",
17241724
snapshot->g2h_outstanding);
17251725

1726-
if (snapshot->ctb)
1727-
xe_print_blob_ascii85(p, "CTB data", '\n',
1726+
if (snapshot->ctb) {
1727+
drm_printf(p, "[CTB].length: 0x%lx\n", snapshot->ctb_size);
1728+
xe_print_blob_ascii85(p, "[CTB].data", '\n',
17281729
snapshot->ctb, 0, snapshot->ctb_size);
1730+
}
17291731
} else {
17301732
drm_puts(p, "CT disabled\n");
17311733
}

drivers/gpu/drm/xe/xe_guc_log.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,10 +208,11 @@ void xe_guc_log_snapshot_print(struct xe_guc_log_snapshot *snapshot, struct drm_
208208
drm_printf(p, "GuC timestamp: 0x%08llX [%llu]\n", snapshot->stamp, snapshot->stamp);
209209
drm_printf(p, "Log level: %u\n", snapshot->level);
210210

211+
drm_printf(p, "[LOG].length: 0x%lx\n", snapshot->size);
211212
remain = snapshot->size;
212213
for (i = 0; i < snapshot->num_chunks; i++) {
213214
size_t size = min(GUC_LOG_CHUNK_SIZE, remain);
214-
const char *prefix = i ? NULL : "Log data";
215+
const char *prefix = i ? NULL : "[LOG].data";
215216
char suffix = i == snapshot->num_chunks - 1 ? '\n' : 0;
216217

217218
xe_print_blob_ascii85(p, prefix, suffix, snapshot->copy[i], 0, size);

0 commit comments

Comments
 (0)