Skip to content

Commit 6280e96

Browse files
committed
drm/atomic-helper: Change parameter name of drm_atomic_helper_cleanup_planes()
drm_atomic_helper_cleanup_planes() is one of the final part of a commit, and will free up all plane resources used in the previous commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Link: https://lore.kernel.org/r/20250213-bridge-connector-v3-24-e71598f49c8f@kernel.org Signed-off-by: Maxime Ripard <mripard@kernel.org>
1 parent e64834b commit 6280e96

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/gpu/drm/drm_atomic_helper.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2989,24 +2989,24 @@ EXPORT_SYMBOL(drm_atomic_helper_disable_planes_on_crtc);
29892989
/**
29902990
* drm_atomic_helper_cleanup_planes - cleanup plane resources after commit
29912991
* @dev: DRM device
2992-
* @old_state: atomic state object with old state structures
2992+
* @state: atomic state object being committed
29932993
*
29942994
* This function cleans up plane state, specifically framebuffers, from the old
2995-
* configuration. Hence the old configuration must be perserved in @old_state to
2995+
* configuration. Hence the old configuration must be perserved in @state to
29962996
* be able to call this function.
29972997
*
29982998
* This function may not be called on the new state when the atomic update
29992999
* fails at any point after calling drm_atomic_helper_prepare_planes(). Use
30003000
* drm_atomic_helper_unprepare_planes() in this case.
30013001
*/
30023002
void drm_atomic_helper_cleanup_planes(struct drm_device *dev,
3003-
struct drm_atomic_state *old_state)
3003+
struct drm_atomic_state *state)
30043004
{
30053005
struct drm_plane *plane;
30063006
struct drm_plane_state *old_plane_state;
30073007
int i;
30083008

3009-
for_each_old_plane_in_state(old_state, plane, old_plane_state, i) {
3009+
for_each_old_plane_in_state(state, plane, old_plane_state, i) {
30103010
const struct drm_plane_helper_funcs *funcs = plane->helper_private;
30113011

30123012
if (funcs->cleanup_fb)

0 commit comments

Comments
 (0)