Skip to content

Commit 6170441

Browse files
Haibo Chenstorulf
authored andcommitted
mmc: sdhci-esdhc-imx: fix few build warnings
drivers/mmc/host/sdhci-esdhc-imx.c:1566 sdhci_esdhc_imx_hwinit() warn: inconsistent indenting drivers/mmc/host/sdhci-esdhc-imx.c:1251 esdhc_executing_tuning() error: uninitialized symbol 'target_min'. drivers/mmc/host/sdhci-esdhc-imx.c:1251 esdhc_executing_tuning() error: uninitialized symbol 'target_max'. Fixes: be953af ("mmc: sdhci-esdhc-imx: widen auto-tuning window for standard tuning") Fixes: 541a95e ("mmc: sdhci-esdhc-imx: optimize the manual tuing logic to get the best timing") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/all/202505160225.Csr5USfq-lkp@intel.com/ Acked-by: Adrian Hunter <adrian.hunter@intel.com> Signed-off-by: Haibo Chen <haibo.chen@nxp.com> Link: https://lore.kernel.org/r/20250516-b4-usdhc-v2-1-3fccd02f5602@nxp.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent e249e58 commit 6170441

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/mmc/host/sdhci-esdhc-imx.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1216,8 +1216,8 @@ static int esdhc_executing_tuning(struct sdhci_host *host, u32 opcode)
12161216
int win_length, target_min, target_max, target_win_length;
12171217
u32 clk_tune_ctrl_status, temp;
12181218

1219-
min = ESDHC_TUNE_CTRL_MIN;
1220-
max = ESDHC_TUNE_CTRL_MIN;
1219+
min = target_min = ESDHC_TUNE_CTRL_MIN;
1220+
max = target_max = ESDHC_TUNE_CTRL_MIN;
12211221
target_win_length = 0;
12221222
while (max < ESDHC_TUNE_CTRL_MAX) {
12231223
/* find the mininum delay first which can pass tuning */
@@ -1591,8 +1591,8 @@ static void sdhci_esdhc_imx_hwinit(struct sdhci_host *host)
15911591
* wider, give auto tuning enough space to handle the sample
15921592
* point shift cause by temperature change.
15931593
*/
1594-
tmp &= ~ESDHC_TUNING_WINDOW_MASK;
1595-
tmp |= FIELD_PREP(ESDHC_TUNING_WINDOW_MASK, ESDHC_AUTO_TUNING_WINDOW);
1594+
tmp &= ~ESDHC_TUNING_WINDOW_MASK;
1595+
tmp |= FIELD_PREP(ESDHC_TUNING_WINDOW_MASK, ESDHC_AUTO_TUNING_WINDOW);
15961596

15971597
/* Disable the CMD CRC check for tuning, if not, need to
15981598
* add some delay after every tuning command, because

0 commit comments

Comments
 (0)