Skip to content

Commit 5f3b133

Browse files
Christoph Hellwigmszyprow
authored andcommitted
dma-mapping: add a dma_need_unmap helper
Add helper that allows a driver to skip calling dma_unmap_* if the DMA layer can guarantee that they are no-nops. Signed-off-by: Christoph Hellwig <hch@lst.de> Tested-by: Jens Axboe <axboe@kernel.dk> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org> Signed-off-by: Leon Romanovsky <leonro@nvidia.com> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
1 parent 433a762 commit 5f3b133

File tree

2 files changed

+23
-0
lines changed

2 files changed

+23
-0
lines changed

include/linux/dma-mapping.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -406,6 +406,7 @@ static inline bool dma_need_sync(struct device *dev, dma_addr_t dma_addr)
406406
{
407407
return dma_dev_need_sync(dev) ? __dma_need_sync(dev, dma_addr) : false;
408408
}
409+
bool dma_need_unmap(struct device *dev);
409410
#else /* !CONFIG_HAS_DMA || !CONFIG_DMA_NEED_SYNC */
410411
static inline bool dma_dev_need_sync(const struct device *dev)
411412
{
@@ -431,6 +432,10 @@ static inline bool dma_need_sync(struct device *dev, dma_addr_t dma_addr)
431432
{
432433
return false;
433434
}
435+
static inline bool dma_need_unmap(struct device *dev)
436+
{
437+
return false;
438+
}
434439
#endif /* !CONFIG_HAS_DMA || !CONFIG_DMA_NEED_SYNC */
435440

436441
struct page *dma_alloc_pages(struct device *dev, size_t size,

kernel/dma/mapping.c

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -443,6 +443,24 @@ bool __dma_need_sync(struct device *dev, dma_addr_t dma_addr)
443443
}
444444
EXPORT_SYMBOL_GPL(__dma_need_sync);
445445

446+
/**
447+
* dma_need_unmap - does this device need dma_unmap_* operations
448+
* @dev: device to check
449+
*
450+
* If this function returns %false, drivers can skip calling dma_unmap_* after
451+
* finishing an I/O. This function must be called after all mappings that might
452+
* need to be unmapped have been performed.
453+
*/
454+
bool dma_need_unmap(struct device *dev)
455+
{
456+
if (!dma_map_direct(dev, get_dma_ops(dev)))
457+
return true;
458+
if (!dev->dma_skip_sync)
459+
return true;
460+
return IS_ENABLED(CONFIG_DMA_API_DEBUG);
461+
}
462+
EXPORT_SYMBOL_GPL(dma_need_unmap);
463+
446464
static void dma_setup_need_sync(struct device *dev)
447465
{
448466
const struct dma_map_ops *ops = get_dma_ops(dev);

0 commit comments

Comments
 (0)