Skip to content

Commit 5ea0bba

Browse files
chleroympe
authored andcommitted
powerpc/64e: Fix wrong test in __ptep_test_and_clear_young()
Commit 45201c8 ("powerpc/nohash: Remove hash related code from nohash headers.") replaced: if ((pte_val(*ptep) & (_PAGE_ACCESSED | _PAGE_HASHPTE)) == 0) return 0; By: if (pte_young(*ptep)) return 0; But it should be: if (!pte_young(*ptep)) return 0; Fix it. Fixes: 45201c8 ("powerpc/nohash: Remove hash related code from nohash headers.") Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://msgid.link/8bb7f06494e21adada724ede47a4c3d97e879d40.1695659959.git.christophe.leroy@csgroup.eu
1 parent 5d9cea8 commit 5ea0bba

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/powerpc/include/asm/nohash/64/pgtable.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ static inline int __ptep_test_and_clear_young(struct mm_struct *mm,
197197
{
198198
unsigned long old;
199199

200-
if (pte_young(*ptep))
200+
if (!pte_young(*ptep))
201201
return 0;
202202
old = pte_update(mm, addr, ptep, _PAGE_ACCESSED, 0, 0);
203203
return (old & _PAGE_ACCESSED) != 0;

0 commit comments

Comments
 (0)