Skip to content

Commit 5a4b5f3

Browse files
author
Jiri Kosina
committed
Merge branch 'for-6.14/intel-ish' into for-linus
- dead code removal in intel-ish-hid driver (Dr. David Alan Gilbert)
2 parents e91b496 + b8842f2 commit 5a4b5f3

File tree

6 files changed

+0
-74
lines changed

6 files changed

+0
-74
lines changed

drivers/hid/intel-ish-hid/ishtp/client-buffers.c

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -251,27 +251,6 @@ int ishtp_cl_io_rb_recycle(struct ishtp_cl_rb *rb)
251251
}
252252
EXPORT_SYMBOL(ishtp_cl_io_rb_recycle);
253253

254-
/**
255-
* ishtp_cl_tx_empty() -test whether client device tx buffer is empty
256-
* @cl: Pointer to client device instance
257-
*
258-
* Look client device tx buffer list, and check whether this list is empty
259-
*
260-
* Return: true if client tx buffer list is empty else false
261-
*/
262-
bool ishtp_cl_tx_empty(struct ishtp_cl *cl)
263-
{
264-
int tx_list_empty;
265-
unsigned long tx_flags;
266-
267-
spin_lock_irqsave(&cl->tx_list_spinlock, tx_flags);
268-
tx_list_empty = list_empty(&cl->tx_list.list);
269-
spin_unlock_irqrestore(&cl->tx_list_spinlock, tx_flags);
270-
271-
return !!tx_list_empty;
272-
}
273-
EXPORT_SYMBOL(ishtp_cl_tx_empty);
274-
275254
/**
276255
* ishtp_cl_rx_get_rb() -Get a rb from client device rx buffer list
277256
* @cl: Pointer to client device instance

drivers/hid/intel-ish-hid/ishtp/client.c

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -14,25 +14,6 @@
1414
#include "hbm.h"
1515
#include "client.h"
1616

17-
int ishtp_cl_get_tx_free_buffer_size(struct ishtp_cl *cl)
18-
{
19-
unsigned long tx_free_flags;
20-
int size;
21-
22-
spin_lock_irqsave(&cl->tx_free_list_spinlock, tx_free_flags);
23-
size = cl->tx_ring_free_size * cl->device->fw_client->props.max_msg_length;
24-
spin_unlock_irqrestore(&cl->tx_free_list_spinlock, tx_free_flags);
25-
26-
return size;
27-
}
28-
EXPORT_SYMBOL(ishtp_cl_get_tx_free_buffer_size);
29-
30-
int ishtp_cl_get_tx_free_rings(struct ishtp_cl *cl)
31-
{
32-
return cl->tx_ring_free_size;
33-
}
34-
EXPORT_SYMBOL(ishtp_cl_get_tx_free_rings);
35-
3617
/**
3718
* ishtp_read_list_flush() - Flush read queue
3819
* @cl: ishtp client instance

drivers/hid/intel-ish-hid/ishtp/client.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,6 @@ int ishtp_cl_alloc_rx_ring(struct ishtp_cl *cl);
120120
int ishtp_cl_alloc_tx_ring(struct ishtp_cl *cl);
121121
void ishtp_cl_free_rx_ring(struct ishtp_cl *cl);
122122
void ishtp_cl_free_tx_ring(struct ishtp_cl *cl);
123-
int ishtp_cl_get_tx_free_buffer_size(struct ishtp_cl *cl);
124-
int ishtp_cl_get_tx_free_rings(struct ishtp_cl *cl);
125123

126124
/* DMA I/F functions */
127125
void recv_ishtp_cl_msg_dma(struct ishtp_device *dev, void *msg,

drivers/hid/intel-ish-hid/ishtp/init.c

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -14,36 +14,6 @@
1414
#include "client.h"
1515
#include "loader.h"
1616

17-
/**
18-
* ishtp_dev_state_str() -Convert to string format
19-
* @state: state to convert
20-
*
21-
* Convert state to string for prints
22-
*
23-
* Return: character pointer to converted string
24-
*/
25-
const char *ishtp_dev_state_str(int state)
26-
{
27-
switch (state) {
28-
case ISHTP_DEV_INITIALIZING:
29-
return "INITIALIZING";
30-
case ISHTP_DEV_INIT_CLIENTS:
31-
return "INIT_CLIENTS";
32-
case ISHTP_DEV_ENABLED:
33-
return "ENABLED";
34-
case ISHTP_DEV_RESETTING:
35-
return "RESETTING";
36-
case ISHTP_DEV_DISABLED:
37-
return "DISABLED";
38-
case ISHTP_DEV_POWER_DOWN:
39-
return "POWER_DOWN";
40-
case ISHTP_DEV_POWER_UP:
41-
return "POWER_UP";
42-
default:
43-
return "unknown";
44-
}
45-
}
46-
4717
/**
4818
* ishtp_device_init() - ishtp device init
4919
* @dev: ISHTP device instance

drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ enum ishtp_dev_state {
5757
ISHTP_DEV_POWER_DOWN,
5858
ISHTP_DEV_POWER_UP
5959
};
60-
const char *ishtp_dev_state_str(int state);
6160

6261
struct ishtp_cl;
6362

include/linux/intel-ish-client-if.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ void ishtp_cl_destroy_connection(struct ishtp_cl *cl, bool reset);
100100
int ishtp_cl_send(struct ishtp_cl *cl, uint8_t *buf, size_t length);
101101
int ishtp_cl_flush_queues(struct ishtp_cl *cl);
102102
int ishtp_cl_io_rb_recycle(struct ishtp_cl_rb *rb);
103-
bool ishtp_cl_tx_empty(struct ishtp_cl *cl);
104103
struct ishtp_cl_rb *ishtp_cl_rx_get_rb(struct ishtp_cl *cl);
105104
void *ishtp_get_client_data(struct ishtp_cl *cl);
106105
void ishtp_set_client_data(struct ishtp_cl *cl, void *data);

0 commit comments

Comments
 (0)