Skip to content

Commit 543bd28

Browse files
plbossartvinodkoul
authored andcommitted
soundwire: mipi-disco: add new properties from 2.0 spec
The DisCo for SoundWire 2.0 spec adds support for new 'mipi-sdw-sdca-interrupt-register-list' and 'mipi-sdw-commit-register-supported'. This patch only adds the definitions and property reads, but the use of these properties will come at some point in the future when needed. Note a slight conceptual disconnect between the MIPI DisCo definition of a boolean property and the Linux implementation. The latter only checks the presence of the property to set its value to 'true', whereas the MIPI definitions allow for a property with a 'false' value. This patch uses the new introduced mipi_device_property_read_bool() to handle it. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> Link: https://lore.kernel.org/r/20241003070650.62787-14-yung-chuan.liao@linux.intel.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 1ab88b5 commit 543bd28

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

drivers/soundwire/mipi_disco.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -398,6 +398,12 @@ int sdw_slave_read_prop(struct sdw_slave *slave)
398398
device_property_read_u32(dev, "mipi-sdw-sink-port-list",
399399
&prop->sink_ports);
400400

401+
device_property_read_u32(dev, "mipi-sdw-sdca-interrupt-register-list",
402+
&prop->sdca_interrupt_register_list);
403+
404+
prop->commit_register_supported = mipi_device_property_read_bool(dev,
405+
"mipi-sdw-commit-register-supported");
406+
401407
/*
402408
* Read dp0 properties - we don't rely on the 'mipi-sdw-dp-0-supported'
403409
* property since the 'mipi-sdw-dp0-subproperties' property is logically

include/linux/soundwire/sdw.h

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,8 +335,11 @@ struct sdw_dpn_prop {
335335
* @master_count: Number of Masters present on this Slave
336336
* @source_ports: Bitmap identifying source ports
337337
* @sink_ports: Bitmap identifying sink ports
338-
* @scp_int1_mask: SCP_INT1_MASK desired settings
339338
* @quirks: bitmask identifying deltas from the MIPI specification
339+
* @sdca_interrupt_register_list: indicates which sets of SDCA interrupt status
340+
* and masks are supported
341+
* @commit_register_supported: is PCP_Commit register supported
342+
* @scp_int1_mask: SCP_INT1_MASK desired settings
340343
* @clock_reg_supported: the Peripheral implements the clock base and scale
341344
* registers introduced with the SoundWire 1.2 specification. SDCA devices
342345
* do not need to set this boolean property as the registers are required.
@@ -363,6 +366,8 @@ struct sdw_slave_prop {
363366
u32 source_ports;
364367
u32 sink_ports;
365368
u32 quirks;
369+
u32 sdca_interrupt_register_list;
370+
u8 commit_register_supported;
366371
u8 scp_int1_mask;
367372
bool clock_reg_supported;
368373
bool use_domain_irq;

0 commit comments

Comments
 (0)