Skip to content

Commit 52fd170

Browse files
learjet5bebarino
authored andcommitted
clk: en7523: Initialize num before accessing hws in en7523_register_clocks()
With the new __counted_by annotation in clk_hw_onecell_data, the "num" struct member must be set before accessing the "hws" array. Failing to do so will trigger a runtime warning when enabling CONFIG_UBSAN_BOUNDS and CONFIG_FORTIFY_SOURCE. Fixes: f316cdf ("clk: Annotate struct clk_hw_onecell_data with __counted_by") Signed-off-by: Haoyu Li <lihaoyu499@gmail.com> Link: https://lore.kernel.org/r/20241203142915.345523-1-lihaoyu499@gmail.com Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 2eb75f8 commit 52fd170

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/clk/clk-en7523.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -504,6 +504,8 @@ static void en7523_register_clocks(struct device *dev, struct clk_hw_onecell_dat
504504
u32 rate;
505505
int i;
506506

507+
clk_data->num = EN7523_NUM_CLOCKS;
508+
507509
for (i = 0; i < ARRAY_SIZE(en7523_base_clks); i++) {
508510
const struct en_clk_desc *desc = &en7523_base_clks[i];
509511
u32 reg = desc->div_reg ? desc->div_reg : desc->base_reg;
@@ -525,8 +527,6 @@ static void en7523_register_clocks(struct device *dev, struct clk_hw_onecell_dat
525527

526528
hw = en7523_register_pcie_clk(dev, np_base);
527529
clk_data->hws[EN7523_CLK_PCIE] = hw;
528-
529-
clk_data->num = EN7523_NUM_CLOCKS;
530530
}
531531

532532
static int en7523_clk_hw_init(struct platform_device *pdev,

0 commit comments

Comments
 (0)