Skip to content

Commit 4e7bca7

Browse files
Hans ZhangKAGA-KOKO
authored andcommitted
PCI/MSI: Use bool for MSI enable state tracking
Convert pci_msi_enable and pci_msi_enabled() to use bool type for clarity. No functional changes, only code cleanup. Signed-off-by: Hans Zhang <hans.zhang@cixtech.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/all/20250516165223.125083-2-18255117159@163.com
1 parent 9442427 commit 4e7bca7

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

drivers/pci/msi/api.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ EXPORT_SYMBOL_GPL(pci_restore_msi_state);
399399
* Return: true if MSI has not been globally disabled through ACPI FADT,
400400
* PCI bridge quirks, or the "pci=nomsi" kernel command-line option.
401401
*/
402-
int pci_msi_enabled(void)
402+
bool pci_msi_enabled(void)
403403
{
404404
return pci_msi_enable;
405405
}

drivers/pci/msi/msi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#include "../pci.h"
1616
#include "msi.h"
1717

18-
int pci_msi_enable = 1;
18+
bool pci_msi_enable = true;
1919

2020
/**
2121
* pci_msi_supported - check whether MSI may be enabled on a device
@@ -970,5 +970,5 @@ EXPORT_SYMBOL(msi_desc_to_pci_dev);
970970

971971
void pci_no_msi(void)
972972
{
973-
pci_msi_enable = 0;
973+
pci_msi_enable = false;
974974
}

drivers/pci/msi/msi.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ static inline __attribute_const__ u32 msi_multi_mask(struct msi_desc *desc)
8787
void msix_prepare_msi_desc(struct pci_dev *dev, struct msi_desc *desc);
8888

8989
/* Subsystem variables */
90-
extern int pci_msi_enable;
90+
extern bool pci_msi_enable;
9191

9292
/* MSI internal functions invoked from the public APIs */
9393
void pci_msi_shutdown(struct pci_dev *dev);

include/linux/pci.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1669,7 +1669,7 @@ void pci_disable_msi(struct pci_dev *dev);
16691669
int pci_msix_vec_count(struct pci_dev *dev);
16701670
void pci_disable_msix(struct pci_dev *dev);
16711671
void pci_restore_msi_state(struct pci_dev *dev);
1672-
int pci_msi_enabled(void);
1672+
bool pci_msi_enabled(void);
16731673
int pci_enable_msi(struct pci_dev *dev);
16741674
int pci_enable_msix_range(struct pci_dev *dev, struct msix_entry *entries,
16751675
int minvec, int maxvec);
@@ -1702,7 +1702,7 @@ static inline void pci_disable_msi(struct pci_dev *dev) { }
17021702
static inline int pci_msix_vec_count(struct pci_dev *dev) { return -ENOSYS; }
17031703
static inline void pci_disable_msix(struct pci_dev *dev) { }
17041704
static inline void pci_restore_msi_state(struct pci_dev *dev) { }
1705-
static inline int pci_msi_enabled(void) { return 0; }
1705+
static inline bool pci_msi_enabled(void) { return false; }
17061706
static inline int pci_enable_msi(struct pci_dev *dev)
17071707
{ return -ENOSYS; }
17081708
static inline int pci_enable_msix_range(struct pci_dev *dev,

0 commit comments

Comments
 (0)