Skip to content

Commit 4e4b179

Browse files
gobenjidavem330
authored andcommitted
vxlan: Add missing entries to vxlan_get_size()
There are some attributes added by vxlan_fill_info() which are not accounted for in vxlan_get_size(). Add them. I didn't find a way to trigger an actual problem from this miscalculation since there is usually extra space in netlink size calculations like if_nlmsg_size(); but maybe I just didn't search long enough. Fixes: 3511494 ("vxlan: Group Policy extension") Fixes: e1e5314 ("vxlan: implement GPE") Fixes: 0ace2ca ("vxlan: Use checksum partial with remote checksum offload") Fixes: f9c4bb0 ("vxlan: vni filtering support on collect metadata device") Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com> Acked-by: Nikolay Aleksandrov <razor@blackwall.org> Reviewed-by: Ido Schimmel <idosch@nvidia.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent f1d95df commit 4e4b179

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/net/vxlan/vxlan_core.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4331,6 +4331,10 @@ static size_t vxlan_get_size(const struct net_device *dev)
43314331
nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_REMCSUM_TX */
43324332
nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_REMCSUM_RX */
43334333
nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_LOCALBYPASS */
4334+
nla_total_size(0) + /* IFLA_VXLAN_GBP */
4335+
nla_total_size(0) + /* IFLA_VXLAN_GPE */
4336+
nla_total_size(0) + /* IFLA_VXLAN_REMCSUM_NOPARTIAL */
4337+
nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_VNIFILTER */
43344338
0;
43354339
}
43364340

0 commit comments

Comments
 (0)