Skip to content

Commit 4c80105

Browse files
author
Al Viro
committed
bdev: move ->bd_write_holder into ->__bd_flags
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent 01e198f commit 4c80105

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

block/bdev.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ static void bd_end_claim(struct block_device *bdev, void *holder)
624624
bdev->bd_holder = NULL;
625625
bdev->bd_holder_ops = NULL;
626626
mutex_unlock(&bdev->bd_holder_lock);
627-
if (bdev->bd_write_holder)
627+
if (bdev_test_flag(bdev, BD_WRITE_HOLDER))
628628
unblock = true;
629629
}
630630
if (!whole->bd_holders)
@@ -640,7 +640,7 @@ static void bd_end_claim(struct block_device *bdev, void *holder)
640640
*/
641641
if (unblock) {
642642
disk_unblock_events(bdev->bd_disk);
643-
bdev->bd_write_holder = false;
643+
bdev_clear_flag(bdev, BD_WRITE_HOLDER);
644644
}
645645
}
646646

@@ -892,9 +892,10 @@ int bdev_open(struct block_device *bdev, blk_mode_t mode, void *holder,
892892
* writeable reference is too fragile given the way @mode is
893893
* used in blkdev_get/put().
894894
*/
895-
if ((mode & BLK_OPEN_WRITE) && !bdev->bd_write_holder &&
895+
if ((mode & BLK_OPEN_WRITE) &&
896+
!bdev_test_flag(bdev, BD_WRITE_HOLDER) &&
896897
(disk->event_flags & DISK_EVENT_FLAG_BLOCK_ON_EXCL_WRITE)) {
897-
bdev->bd_write_holder = true;
898+
bdev_set_flag(bdev, BD_WRITE_HOLDER);
898899
unblock_events = false;
899900
}
900901
}

include/linux/blk_types.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ struct block_device {
4848
atomic_t __bd_flags; // partition number + flags
4949
#define BD_PARTNO 255 // lower 8 bits; assign-once
5050
#define BD_READ_ONLY (1u<<8) // read-only policy
51-
bool bd_write_holder;
51+
#define BD_WRITE_HOLDER (1u<<9)
5252
bool bd_has_submit_bio;
5353
dev_t bd_dev;
5454
struct inode *bd_inode; /* will die */

0 commit comments

Comments
 (0)