Skip to content

Commit 4c59c59

Browse files
asdfugilgregkh
authored andcommitted
tty: serial: samsung: Use bit manipulation macros for APPLE_S5L_*
New entries using BIT() will be added soon, so change the existing ones to use bit manipulation macros including BIT() and GENMASK() for consistency. Suggested-by: Krzysztof Kozlowski <krzk@kernel.org> Tested-by: Janne Grunau <j@jannau.net> Reviewed-by: Neal Gompa <neal@gompa.dev> Signed-off-by: Nick Chan <towinchenmi@gmail.com> Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Link: https://lore.kernel.org/r/20240911050741.14477-2-towinchenmi@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent f16dd10 commit 4c59c59

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

include/linux/serial_s3c.h

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -249,9 +249,9 @@
249249
#define APPLE_S5L_UCON_RXTO_ENA 9
250250
#define APPLE_S5L_UCON_RXTHRESH_ENA 12
251251
#define APPLE_S5L_UCON_TXTHRESH_ENA 13
252-
#define APPLE_S5L_UCON_RXTO_ENA_MSK (1 << APPLE_S5L_UCON_RXTO_ENA)
253-
#define APPLE_S5L_UCON_RXTHRESH_ENA_MSK (1 << APPLE_S5L_UCON_RXTHRESH_ENA)
254-
#define APPLE_S5L_UCON_TXTHRESH_ENA_MSK (1 << APPLE_S5L_UCON_TXTHRESH_ENA)
252+
#define APPLE_S5L_UCON_RXTO_ENA_MSK BIT(APPLE_S5L_UCON_RXTO_ENA)
253+
#define APPLE_S5L_UCON_RXTHRESH_ENA_MSK BIT(APPLE_S5L_UCON_RXTHRESH_ENA)
254+
#define APPLE_S5L_UCON_TXTHRESH_ENA_MSK BIT(APPLE_S5L_UCON_TXTHRESH_ENA)
255255

256256
#define APPLE_S5L_UCON_DEFAULT (S3C2410_UCON_TXIRQMODE | \
257257
S3C2410_UCON_RXIRQMODE | \
@@ -260,10 +260,10 @@
260260
APPLE_S5L_UCON_RXTHRESH_ENA_MSK | \
261261
APPLE_S5L_UCON_TXTHRESH_ENA_MSK)
262262

263-
#define APPLE_S5L_UTRSTAT_RXTHRESH (1<<4)
264-
#define APPLE_S5L_UTRSTAT_TXTHRESH (1<<5)
265-
#define APPLE_S5L_UTRSTAT_RXTO (1<<9)
266-
#define APPLE_S5L_UTRSTAT_ALL_FLAGS (0x3f0)
263+
#define APPLE_S5L_UTRSTAT_RXTHRESH BIT(4)
264+
#define APPLE_S5L_UTRSTAT_TXTHRESH BIT(5)
265+
#define APPLE_S5L_UTRSTAT_RXTO BIT(9)
266+
#define APPLE_S5L_UTRSTAT_ALL_FLAGS GENMASK(9, 4)
267267

268268
#ifndef __ASSEMBLY__
269269

0 commit comments

Comments
 (0)