Skip to content

Commit 48fc437

Browse files
committed
Merge tag 'drm-intel-fixes-2024-12-25' of https://gitlab.freedesktop.org/drm/i915/kernel into drm-fixes
- Fix C10 pll programming sequence [cx0_phy] (Suraj Kandpal) - Fix power gate sequence. [dg1] (Rodrigo Vivi) Signed-off-by: Dave Airlie <airlied@redhat.com> From: Tvrtko Ursulin <tursulin@igalia.com> Link: https://patchwork.freedesktop.org/patch/msgid/Z2wKf7tmElKFdnoP@linux
2 parents 3bce3cc + 20e7c53 commit 48fc437

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

drivers/gpu/drm/i915/display/intel_cx0_phy.c

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2115,14 +2115,6 @@ static void intel_c10_pll_program(struct intel_display *display,
21152115
0, C10_VDR_CTRL_MSGBUS_ACCESS,
21162116
MB_WRITE_COMMITTED);
21172117

2118-
/* Custom width needs to be programmed to 0 for both the phy lanes */
2119-
intel_cx0_rmw(encoder, INTEL_CX0_BOTH_LANES, PHY_C10_VDR_CUSTOM_WIDTH,
2120-
C10_VDR_CUSTOM_WIDTH_MASK, C10_VDR_CUSTOM_WIDTH_8_10,
2121-
MB_WRITE_COMMITTED);
2122-
intel_cx0_rmw(encoder, INTEL_CX0_BOTH_LANES, PHY_C10_VDR_CONTROL(1),
2123-
0, C10_VDR_CTRL_UPDATE_CFG,
2124-
MB_WRITE_COMMITTED);
2125-
21262118
/* Program the pll values only for the master lane */
21272119
for (i = 0; i < ARRAY_SIZE(pll_state->pll); i++)
21282120
intel_cx0_write(encoder, INTEL_CX0_LANE0, PHY_C10_VDR_PLL(i),
@@ -2132,6 +2124,10 @@ static void intel_c10_pll_program(struct intel_display *display,
21322124
intel_cx0_write(encoder, INTEL_CX0_LANE0, PHY_C10_VDR_CMN(0), pll_state->cmn, MB_WRITE_COMMITTED);
21332125
intel_cx0_write(encoder, INTEL_CX0_LANE0, PHY_C10_VDR_TX(0), pll_state->tx, MB_WRITE_COMMITTED);
21342126

2127+
/* Custom width needs to be programmed to 0 for both the phy lanes */
2128+
intel_cx0_rmw(encoder, INTEL_CX0_BOTH_LANES, PHY_C10_VDR_CUSTOM_WIDTH,
2129+
C10_VDR_CUSTOM_WIDTH_MASK, C10_VDR_CUSTOM_WIDTH_8_10,
2130+
MB_WRITE_COMMITTED);
21352131
intel_cx0_rmw(encoder, INTEL_CX0_LANE0, PHY_C10_VDR_CONTROL(1),
21362132
0, C10_VDR_CTRL_MASTER_LANE | C10_VDR_CTRL_UPDATE_CFG,
21372133
MB_WRITE_COMMITTED);

drivers/gpu/drm/i915/gt/intel_rc6.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ static void gen11_rc6_enable(struct intel_rc6 *rc6)
133133
GEN9_MEDIA_PG_ENABLE |
134134
GEN11_MEDIA_SAMPLER_PG_ENABLE;
135135

136-
if (GRAPHICS_VER(gt->i915) >= 12) {
136+
if (GRAPHICS_VER(gt->i915) >= 12 && !IS_DG1(gt->i915)) {
137137
for (i = 0; i < I915_MAX_VCS; i++)
138138
if (HAS_ENGINE(gt, _VCS(i)))
139139
pg_enable |= (VDN_HCP_POWERGATE_ENABLE(i) |

0 commit comments

Comments
 (0)