Skip to content

Commit 4596cbe

Browse files
spandruvadarafaeljw
authored andcommitted
thermal: intel: Remove explicit user_space governor selection
Currently some user space programs like Linux thermald needs to register to get notifications from both thermal user space governor and also Thermal netlink. This is required as some messages like HFI (Hardware Feedback Notifications) requires Thermal netlink. This results in additional processing in kernel and user space to process both notifications. The cost of using user space governor using kobject_uevent is much higher as this is also used by other user space daemons like udev daemon. Do not select user_space thermal governor by default. If it is present user space programs can always use this governor by writing to "policy" attribute. Instead from the kernel select THERMAL_NETLINK. Trip temperature violation can be received by user space programs via thermal netlink events: THERMAL_GENL_EVENT_TZ_TRIP_UP THERMAL_GENL_EVENT_TZ_TRIP_DOWN Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Link: https://patch.msgid.link/20241216190821.1137162-1-srinivas.pandruvada@linux.intel.com Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 3fd3697 commit 4596cbe

File tree

5 files changed

+2
-5
lines changed

5 files changed

+2
-5
lines changed

drivers/thermal/intel/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ config INTEL_TCC
2222
config X86_PKG_TEMP_THERMAL
2323
tristate "X86 package temperature thermal driver"
2424
depends on X86_THERMAL_VECTOR
25-
select THERMAL_GOV_USER_SPACE
25+
select THERMAL_NETLINK
2626
select INTEL_TCC
2727
default m
2828
help

drivers/thermal/intel/int340x_thermal/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
config INT340X_THERMAL
77
tristate "ACPI INT340X thermal drivers"
88
depends on X86_64 && ACPI && PCI
9-
select THERMAL_GOV_USER_SPACE
9+
select THERMAL_NETLINK
1010
select ACPI_THERMAL_REL
1111
select ACPI_FAN
1212
select ACPI_THERMAL_LIB

drivers/thermal/intel/int340x_thermal/int3400_thermal.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,6 @@ static struct thermal_zone_device_ops int3400_thermal_ops = {
521521
};
522522

523523
static struct thermal_zone_params int3400_thermal_params = {
524-
.governor_name = "user_space",
525524
.no_hwmon = true,
526525
};
527526

drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ static int int340x_thermal_read_trips(struct acpi_device *zone_adev,
105105
}
106106

107107
static struct thermal_zone_params int340x_thermal_params = {
108-
.governor_name = "user_space",
109108
.no_hwmon = true,
110109
};
111110

drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,6 @@ static const struct thermal_zone_device_ops tzone_ops = {
272272
};
273273

274274
static struct thermal_zone_params tzone_params = {
275-
.governor_name = "user_space",
276275
.no_hwmon = true,
277276
};
278277

0 commit comments

Comments
 (0)