Skip to content

Commit 44c5aa7

Browse files
Bartosz GolaszewskiGeorgi Djakov
authored andcommitted
interconnect: icc-clk: check return values of devm_kasprintf()
devm_kasprintf() can fail and return NULL, add missing return value checks. Fixes: 0ac2a08 ("interconnect: add clk-based icc provider support") Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Link: https://lore.kernel.org/r/20241202165723.17292-1-brgl@bgdev.pl Signed-off-by: Georgi Djakov <djakov@kernel.org>
1 parent 00a973e commit 44c5aa7

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

drivers/interconnect/icc-clk.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,11 @@ struct icc_provider *icc_clk_register(struct device *dev,
116116
}
117117

118118
node->name = devm_kasprintf(dev, GFP_KERNEL, "%s_master", data[i].name);
119+
if (!node->name) {
120+
ret = -ENOMEM;
121+
goto err;
122+
}
123+
119124
node->data = &qp->clocks[i];
120125
icc_node_add(node, provider);
121126
/* link to the next node, slave */
@@ -129,6 +134,11 @@ struct icc_provider *icc_clk_register(struct device *dev,
129134
}
130135

131136
node->name = devm_kasprintf(dev, GFP_KERNEL, "%s_slave", data[i].name);
137+
if (!node->name) {
138+
ret = -ENOMEM;
139+
goto err;
140+
}
141+
132142
/* no data for slave node */
133143
icc_node_add(node, provider);
134144
onecell->nodes[j++] = node;

0 commit comments

Comments
 (0)